Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_virtual_network - fixes deadlock issue where multiple subnets shared the same NSG #620

Merged
merged 2 commits into from
Dec 12, 2017

Conversation

tombuildsstuff
Copy link
Contributor

Fixes #373 - where multiple subnets sharing the same Network Security Group name would cause deadlock

```
$ acctests azurerm TestAccAzureRMVirtualNetwork_bug373
=== RUN   TestAccAzureRMVirtualNetwork_bug373
--- PASS: TestAccAzureRMVirtualNetwork_bug373 (102.89s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm    102.911s
```
@tombuildsstuff
Copy link
Contributor Author

Tests pass:

screen shot 2017-12-12 at 14 29 35

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tombuildsstuff tombuildsstuff merged commit beaccf5 into master Dec 12, 2017
@tombuildsstuff tombuildsstuff deleted the virtual-network-lock-fix branch December 12, 2017 15:28
tombuildsstuff added a commit that referenced this pull request Dec 12, 2017
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vnet hangs indefinitely on destroy
2 participants