Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: azurerm_frontdoor_firewall_policy add validation for Frontdoor WAF Name Restrictions #5943

Merged
merged 2 commits into from
Feb 29, 2020

Conversation

WodansSon
Copy link
Collaborator

(fixes #5932)

@WodansSon WodansSon added this to the v2.1.0 milestone Feb 28, 2020
@WodansSon WodansSon requested a review from katbyte February 28, 2020 22:52
@ghost ghost added the size/XS label Feb 28, 2020
@ghost ghost added size/M and removed size/XS labels Feb 29, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@WodansSon
Copy link
Collaborator Author

image

@WodansSon WodansSon merged commit ccd40ae into master Feb 29, 2020
WodansSon added a commit that referenced this pull request Feb 29, 2020
@WodansSon WodansSon deleted the b_frontdoor_waf_name branch February 29, 2020 02:10
@ghost
Copy link

ghost commented Mar 11, 2020

This has been released in version 2.1.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.1.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate Frontdoor WAF Name Restrictions
2 participants