Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Data Source: 'azurerm_iothub_dps_shared_access_policy' #5516

Merged

Conversation

jackbatzner
Copy link
Contributor

@jackbatzner jackbatzner commented Jan 24, 2020

Add new data source 'azurerm_iothub_dps_shared_access_policy'

=== RUN TestAccDataSourceAzureRMIotHubDpsSharedAccessPolicy_basic
=== PAUSE TestAccDataSourceAzureRMIotHubDpsSharedAccessPolicy_basic
=== CONT TestAccDataSourceAzureRMIotHubDpsSharedAccessPolicy_basic
--- PASS: TestAccDataSourceAzureRMIotHubDpsSharedAccessPolicy_basic (303.44s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/iothub/tests 303.714s

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank for the datasource @Brunhil! just some comments about the doc wording but otherwise looks good

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @Brunhil

Thanks for pushing those changes - apologies for the delayed re-review here!

I've taken a look through and left some minor comments inline but this otherwise LGTM - since these also need to be made in the Resource too I'm going to push a commit to fix this & rebase this so that we can get this merged, I hope you don't mind!

Thanks!

@tombuildsstuff tombuildsstuff force-pushed the iothub_dps_sap_datasource branch from 8e91168 to 26cd458 Compare February 11, 2020 15:11
@tombuildsstuff tombuildsstuff dismissed katbyte’s stale review February 11, 2020 15:13

dismissing since changes have been pushed

@tombuildsstuff
Copy link
Contributor

Test passes:

Screenshot 2020-02-11 at 16 25 19

@tombuildsstuff tombuildsstuff merged commit b65373d into hashicorp:master Feb 11, 2020
tombuildsstuff added a commit that referenced this pull request Feb 11, 2020
@ghost
Copy link

ghost commented Feb 12, 2020

This has been released in version 1.44.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.44.0"
}
# ... other configuration ...

@jackbatzner jackbatzner deleted the iothub_dps_sap_datasource branch March 14, 2020 14:48
@ghost
Copy link

ghost commented Mar 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants