New Data Source/Resource: azurerm_dedicated_host
#5513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombuildsstuff
force-pushed
the
dedicated_host
branch
from
5b12f0c to
6ba7bf8
Compare
jackofallops
approved these changes
Jan 24, 2020
azurerm/internal/services/compute/tests/resource_arm_dedicated_host_test.go
Show resolved
Hide resolved
| @@ -103,3 +105,11 @@ func validateDiskSizeGB(v interface{}, _ string) (warnings []string, errors []er | |||
| } | |||
| return warnings, errors | |||
| } | |||
|
|
|||
| func validateDedicatedHostGroupName() func(i interface{}, k string) (warnings []string, errors []error) { | |||
| return validation.StringMatch(regexp.MustCompile(`^[^_\W][\w-.]{0,78}[\w]$`), "") | |||
There was a problem hiding this comment.
I suspect this regex may need tweaking, but since I'm unable to put my hands on the naming rules, I'm not completely sure. Worth checking later.
tombuildsstuff
force-pushed
the
dedicated_host
branch
2 times, most recently
from
8a256fa to
58efb83
Compare
|
Resource Tests pass: |
Includes: - custom parser function - rename `sku` to `sku_name` - multi-line code to oneline - increase each timeout of state polling for eventual consistency from 5sec to 10 sec, to alleviate
tombuildsstuff
force-pushed
the
dedicated_host
branch
from
58efb83 to
137183a
Compare
tombuildsstuff
force-pushed
the
dedicated_host
branch
from
137183a to
a323a71
Compare
|
Data Source tests pass: |
tombuildsstuff
added a commit
that referenced
this pull request
Jan 24, 2020
|
This has been released in version 1.42.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.42.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the changes from @magodo in #5417 with the PR comments resolved so that this can be merged - which is a requirement for the new VM Resources.