Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_databricks_workspace: support for the no_public_ip custom parameter #5469

Merged
merged 4 commits into from
Jan 22, 2020

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Jan 22, 2020

No description provided.

@katbyte katbyte added this to the v1.42.0 milestone Jan 22, 2020
@katbyte katbyte requested a review from a team January 22, 2020 00:01
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I did see a failing test. Not sure if that's transient or not

--- FAIL: TestAccAzureRMDatabricksWorkspace_update (1394.16s)
    testing.go:569: Step 2 error: errors during apply:
        
        Error: Cannot read Databricks Workspace "acctestDBW-200122000719930261" (Resource Group "acctestRG-db-200122000719930261") ID
        
          on /opt/teamcity-agent/temp/buildTmp/tf-test103242477/main.tf line 7:
          (source code not available)
        
        

@katbyte katbyte merged commit b7d1cca into master Jan 22, 2020
@katbyte katbyte deleted the kt/databricks-nopubip branch January 22, 2020 19:14
katbyte added a commit that referenced this pull request Jan 22, 2020
@ghost
Copy link

ghost commented Jan 27, 2020

This has been released in version 1.42.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.42.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants