New Data Source: azurerm_storage_container

[minzhang28]

This is to address the request of support storage account container:
#5310

Test Result

=== RUN   TestAccDataSourceArmStorageContainer_basic
=== PAUSE TestAccDataSourceArmStorageContainer_basic
=== CONT  TestAccDataSourceArmStorageContainer_basic
--- PASS: TestAccDataSourceArmStorageContainer_basic (130.38s)
PASS

[tombuildsstuff]

hey @minzhang28

Thanks for this PR :)

I've taken a look through and left some comments inline but this is off to a good start - if we can fix up the comments (and the tests pass) then this otherwise LGTM 👍

Thanks!

[tombuildsstuff]

hey @minzhang28

Thanks for pushing those changes - I've taken a look through and run the tests which led to a few more comments but this is looking good to me; if we can fix up the comments (and the tests pass) then this otherwise looks good to me 👍

Thanks!

[tombuildsstuff]

since we need this field to be set in order to look it up, we can remove this:

Suggested change

resource.TestCheckResourceAttr(data.ResourceName, "storage_account_name", "acctestsadsc"+data.RandomString),

[tombuildsstuff]

looks like this was missed - can we remove this?

[minzhang28]

hey @minzhang28

Thanks for pushing those changes - I've taken a look through and run the tests which led to a few more comments but this is looking good to me; if we can fix up the comments (and the tests pass) then this otherwise looks good to me 👍

Thanks!

Hi @tombuildsstuff
Thank you for your comments.
I've addressed all of them and test passed on my end, please let me know if there's any changes in your mind needs to be changed, thanks again.

[tombuildsstuff]

hey @minzhang28

Thanks for pushing those changes - taking a look through besides one minor comment (which I hope you don't mind but I'm going to push a commit for to get this merged) this otherwise LGTM 👍

Thanks!

[tombuildsstuff]

looks like this was missed - can we remove this?

[tombuildsstuff]

Tests pass:

[ghost]

This has been released in version 1.41.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.41.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!