azurerm_kubernetes_cluster - add managed_cluster_identity support
#5168
Conversation
mbfrahry
changed the title
azurerm_kubernetes_cluster - add managed_cluster_identity_supportazurerm_kubernetes_cluster - add managed_cluster_identity support
| managedClusterIdentityRaw := d.Get("managed_cluster_identity").([]interface{}) | ||
| managedClusterIdentity := expandKubernetesClusterManagedClusterIdentity(managedClusterIdentityRaw) | ||
| existing.Identity = managedClusterIdentity |
There was a problem hiding this comment.
minor but this could be
existing.Identity = expandKubernetesClusterManagedClusterIdentity(d.Get("managed_cluster_identity"))
if the expand sig is changed
| managedClusterIdentity := &containerservice.ManagedClusterIdentity{ | ||
| Type: containerservice.ResourceIdentityType(val["type"].(string)), | ||
| } | ||
|
|
||
| return managedClusterIdentity |
There was a problem hiding this comment.
This could also be
return &containerservice.ManagedClusterIdentity{
Type: containerservice.ResourceIdentityType(val["type"].(string)),
}
as there is no value is assigning it to a var
| return nil | ||
| } | ||
|
|
||
| val := input[0].(map[string]interface{}) |
There was a problem hiding this comment.
would values make more sense?
| val := input[0].(map[string]interface{}) | |
| values := input[0].(map[string]interface{}) |
Co-Authored-By: Tracy P Holmes <[email protected]>
|
This has been released in version 1.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.40.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Address #4506