Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new resource 'azurerm_private_dns_srv_record' #4783

Merged
merged 20 commits into from
Nov 17, 2019

Conversation

phires
Copy link
Contributor

@phires phires commented Oct 31, 2019

New Resource 'azurerm_private_dns_srv_record' for SRV DNS records in Private DNS Zones.
Fixes issue #4739

katbyte
katbyte previously requested changes Nov 1, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @phires,

Over all this looks great! i've left a couple minor comments inline that need to be addressed before merge.

azurerm/resource_arm_private_dns_srv_record.go Outdated Show resolved Hide resolved
azurerm/resource_arm_private_dns_srv_record.go Outdated Show resolved Hide resolved
azurerm/resource_arm_private_dns_srv_record.go Outdated Show resolved Hide resolved
website/docs/r/private_dns_srv_record.html.markdown Outdated Show resolved Hide resolved
website/docs/r/private_dns_srv_record.html.markdown Outdated Show resolved Hide resolved
website/docs/r/private_dns_srv_record.html.markdown Outdated Show resolved Hide resolved
website/docs/r/private_dns_srv_record.html.markdown Outdated Show resolved Hide resolved
website/docs/r/private_dns_srv_record.html.markdown Outdated Show resolved Hide resolved
@katbyte katbyte added this to the v1.37.0 milestone Nov 1, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @phires

Thanks for pushing those changes - aside from a couple of minor issues in the documentation this otherwise LGTM 👍

Thanks!

@phires phires requested a review from katbyte November 14, 2019 09:58
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @phires

Thanks for pushing those changes - taking a look through this now LGTM 👍

Thanks!

@tombuildsstuff tombuildsstuff dismissed katbyte’s stale review November 17, 2019 09:04

dismissing since changes have been pushed

Type: schema.TypeString,
Required: true,
ForceNew: true,
ValidateFunc: validate.NoEmptyStrings,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

running the tests it appears due to the API bug outlined below that the name is also lower-cased in the API response. Since DNS addresses themselves need to be lower-cased - I hope you don't mind but I'm going to push a commit to add some validation to this resource (and the other Private DNS resources) to ensure that the name field is lower-cased

@tombuildsstuff
Copy link
Contributor

With the validation/test changes the tests now pass:

Screenshot 2019-11-17 at 15 25 14

@tombuildsstuff tombuildsstuff merged commit 93dffcf into hashicorp:master Nov 17, 2019
tombuildsstuff added a commit that referenced this pull request Nov 17, 2019
@phires phires deleted the private-dns-srv branch November 18, 2019 12:42
@ghost
Copy link

ghost commented Nov 26, 2019

This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.37.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants