-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new resource 'azurerm_private_dns_srv_record' #4783
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @phires,
Over all this looks great! i've left a couple minor comments inline that need to be addressed before merge.
Co-Authored-By: kt <[email protected]>
Co-Authored-By: kt <[email protected]>
Co-Authored-By: kt <[email protected]>
Co-Authored-By: kt <[email protected]>
Co-Authored-By: kt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @phires
Thanks for pushing those changes - aside from a couple of minor issues in the documentation this otherwise LGTM 👍
Thanks!
Co-Authored-By: Tom Harvey <[email protected]>
Co-Authored-By: Tom Harvey <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dismissing since changes have been pushed
Type: schema.TypeString, | ||
Required: true, | ||
ForceNew: true, | ||
ValidateFunc: validate.NoEmptyStrings, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
running the tests it appears due to the API bug outlined below that the name is also lower-cased in the API response. Since DNS addresses themselves need to be lower-cased - I hope you don't mind but I'm going to push a commit to add some validation to this resource (and the other Private DNS resources) to ensure that the name field is lower-cased
This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.37.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
New Resource 'azurerm_private_dns_srv_record' for SRV DNS records in Private DNS Zones.
Fixes issue #4739