support minor version of java in azurerm_app_service settings

[aczelandi]

Fixes #4318

[tombuildsstuff]

hey @aczelandi

Thanks for this PR :)

Taking a look through this is looking good - if we can fix up the minor comments then this otherwise LGTM 👍

Thanks!

[tombuildsstuff]

hey @aczelandi

Thanks for pushing those changes - taking a look through this LGTM 👍

I've kicked off the tests and there's a couple of failures with the Java 11 tests - but if we can fix those up (which I think is just setting the correct minor version) then we should be good
👍

Thanks!

[aczelandi]

hi @tombuildsstuff, good catch, thanks!
It seems Azure does not support minor versions for Java 11 (I tried all existing versions and keep getting the same Bad Request).
I updated the docs/tests to reflects this.

I am not sure though about TestAccAzureRMAppService_linuxFxVersion, could you send me a screenshot with details? This one does not seem related to Java.

[katbyte]

@aczelandi,

I wouldn't worry about TestAccAzureRMAppService_linuxFxVersion, it's been failing on master for almost a month now, but here it is:

------- Stdout: -------
=== RUN   TestAccAzureRMAppService_linuxFxVersion
=== PAUSE TestAccAzureRMAppService_linuxFxVersion
=== CONT  TestAccAzureRMAppService_linuxFxVersion
--- FAIL: TestAccAzureRMAppService_linuxFxVersion (86.49s)
    testing.go:569: Step 0 error: errors during apply:
        
        Error: Error creating App Service "acctestAS-191103035435793800" (Resource Group "acctestRG-191103035435793800"): web.AppsClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="BadRequest" Message="The parameter LinuxFxVersion has an invalid value." Details=[{"Message":"The parameter LinuxFxVersion has an invalid value."},{"Code":"BadRequest"},{"ErrorEntity":{"Code":"BadRequest","ExtendedCode":"01007","Message":"The parameter LinuxFxVersion has an invalid value.","MessageTemplate":"The parameter {0} has an invalid value.","Parameters":["LinuxFxVersion"]}}]
        
          on /opt/teamcity-agent/temp/buildTmp/tf-test491210449/main.tf line 18:
          (source code not available)
        
        
FAIL

------- Stderr: -------
2019/11/03 03:54:35 [DEBUG] Registering Data Sources for "Compute"..
2019/11/03 03:54:35 [DEBUG] Registering Resources for "Compute"..

[aczelandi]

hi @tombuildsstuff,

could you try to rerun the tests and see if they were fixed?

[tombuildsstuff]

@aczelandi tests look good - thanks for this:

[tombuildsstuff]

LGTM - thanks for pushing those changes @aczelandi

[ghost]

This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.37.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!