Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/key_vault / r/maps: making the sku case insensitive temporarily #4714

Merged
merged 2 commits into from
Oct 25, 2019

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Oct 24, 2019

Breaking Changes in the Azure API mean that the Sku's defined in the Swagger (in lower-case) no longer match the return type. This PR temporarily makes the sku name case-insensitive for the Key Vault and Maps Account resources - to allow users to continue working; in 2.0 we'll replace these lower-cased versions with Title Case versions as is now being returned in the API, and then revert the case insensitivity fix in this PR

Fixes #4707
Fixes #4706

@tombuildsstuff tombuildsstuff added bug service/key-vault Key Vault upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR service/maps labels Oct 24, 2019
@tombuildsstuff tombuildsstuff added this to the v1.36.0 milestone Oct 24, 2019
@tombuildsstuff tombuildsstuff requested a review from a team October 24, 2019 17:25
@ghost ghost added the size/XS label Oct 24, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit 7fb9913 into master Oct 25, 2019
@tombuildsstuff tombuildsstuff deleted the b/sku-case-sensitivity branch October 25, 2019 14:20
tombuildsstuff added a commit that referenced this pull request Oct 25, 2019
@ghost
Copy link

ghost commented Oct 29, 2019

This has been released in version 1.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.36.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 24, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug service/key-vault Key Vault service/maps size/XS upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_key_vault problem is sku casing azurerm_maps_account wants to replace because of casing in SKU
2 participants