Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3319] datalakestore gen2 filesystem resource #4457

Merged
merged 6 commits into from
Oct 2, 2019

Conversation

tcz001
Copy link
Contributor

@tcz001 tcz001 commented Sep 30, 2019

This PR implements new resource of datalakestore gen2 filesystem, which requires giovanni recent support for adls gen2

This change should close #3319 feature request, I'm working on another PR to support data_source, will come back soon.

@ghost ghost added the size/S label Sep 30, 2019
@tcz001
Copy link
Contributor Author

tcz001 commented Sep 30, 2019

Hi @tombuildsstuff , could you please review and let me know if any more changes required, Thanks

@tcz001 tcz001 force-pushed the upstream-issue-3319 branch from 30a4dd3 to 9ff238d Compare September 30, 2019 07:49
@ghost ghost added size/XL and removed size/S labels Sep 30, 2019
@ghost ghost added the dependencies label Sep 30, 2019
@tcz001
Copy link
Contributor Author

tcz001 commented Sep 30, 2019

@tombuildsstuff the travis tests are failing due to vendor file missing, should I enforce to add track of the filesystems on it?

@tombuildsstuff
Copy link
Contributor

@tcz001 yep - if you don't mind I'll push a commit to fix that so that we can work through & review this :)

@tombuildsstuff tombuildsstuff self-assigned this Oct 1, 2019
@tcz001
Copy link
Contributor Author

tcz001 commented Oct 1, 2019

@tombuildsstuff Thanks, I've fixed the lintrest issues, should be ready for review

@tcz001 tcz001 force-pushed the upstream-issue-3319 branch from 507d07f to c909e4d Compare October 1, 2019 18:39
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @tcz001

Thanks for this PR :)

Taking a look through whilst this is off to a good start, after some discussions internally yesterday we need to take a slightly different direction for the Storage Resources going forward, primarily by using the Storage Account ID rather than the Storage Account Name to allow us to reduce some API calls.

Since we don't have any examples of this in the repository - I hope you don't mind but I'm going to push a couple of commits to both fix the comments I've left in-line - and update this to using an ID for the Storage Account, rather than the Name.

Thanks!

azurerm/resource_arm_storage_filesystem.go Outdated Show resolved Hide resolved
azurerm/internal/services/storage/client.go Outdated Show resolved Hide resolved
azurerm/resource_arm_storage_filesystem.go Outdated Show resolved Hide resolved
azurerm/resource_arm_storage_filesystem.go Outdated Show resolved Hide resolved
azurerm/resource_arm_storage_filesystem.go Outdated Show resolved Hide resolved
azurerm/resource_arm_storage_filesystem.go Outdated Show resolved Hide resolved
azurerm/resource_arm_storage_filesystem.go Outdated Show resolved Hide resolved
azurerm/config.go Outdated Show resolved Hide resolved
azurerm/resource_arm_storage_filesystem.go Outdated Show resolved Hide resolved
azurerm/resource_arm_storage_filesystem.go Outdated Show resolved Hide resolved
@tombuildsstuff
Copy link
Contributor

Tests Pass:

Screenshot 2019-10-02 at 15 34 49

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor question

@tombuildsstuff tombuildsstuff merged commit 7a8e3ed into hashicorp:master Oct 2, 2019
tombuildsstuff added a commit that referenced this pull request Oct 2, 2019
@ghost
Copy link

ghost commented Oct 4, 2019

This has been released in version 1.35.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.35.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Data Lake Storage Gen2 filesystem
3 participants