-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for App Insights Analytics Items #4374
Add support for App Insights Analytics Items #4374
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @stuartleeks
Thanks for this PR :)
Taking a look through this mostly LGTM - if we can switch to parsing the ID from the URI that should fix most of the outstanding comments, but this is otherwise looking good 👍
Thanks!
azurerm/resource_arm_application_insights_analytics_item_test.go
Outdated
Show resolved
Hide resolved
website/docs/r/application_insights_analytics_item.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/application_insights_analytics_item.html.markdown
Outdated
Show resolved
Hide resolved
4bc7b89
to
3205d9f
Compare
@tombuildsstuff I have made changes that hopefully address your feedback (and rebased on latest master). Let me know if there are any further changes needed before this can be merged :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @stuartleeks. We're so close here. We just need to check import after every test step and then we'll be good to go
website/docs/r/application_insights_analytics_item.html.markdown
Outdated
Show resolved
Hide resolved
Co-Authored-By: Tom Harvey <[email protected]>
Resource group name can be derived from the app insights id
Co-Authored-By: Matthew Frahry <[email protected]>
94e8910
to
8c0869e
Compare
@mbfrahry - thanks for the review. I think I've addressed your comments, but let me know if there's anything I missed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the review @stuartleeks! Merging now
This has been released in version 1.35.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.35.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
App Insights supports saved queries and functions (referred to as Analytics Items in the API/SDKs).
This PR adds a resource for App Insights Analytics Items.