Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for App Insights Analytics Items #4374

Merged
merged 36 commits into from
Oct 1, 2019

Conversation

stuartleeks
Copy link
Contributor

App Insights supports saved queries and functions (referred to as Analytics Items in the API/SDKs).

This PR adds a resource for App Insights Analytics Items.

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @stuartleeks

Thanks for this PR :)

Taking a look through this mostly LGTM - if we can switch to parsing the ID from the URI that should fix most of the outstanding comments, but this is otherwise looking good 👍

Thanks!

@tombuildsstuff tombuildsstuff added this to the v1.35.0 milestone Sep 19, 2019
@stuartleeks stuartleeks force-pushed the appinsights-analyticsitems branch from 4bc7b89 to 3205d9f Compare September 23, 2019 14:37
@stuartleeks
Copy link
Contributor Author

@tombuildsstuff I have made changes that hopefully address your feedback (and rebased on latest master). Let me know if there are any further changes needed before this can be merged :-)

@ghost ghost removed the waiting-response label Sep 23, 2019
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @stuartleeks. We're so close here. We just need to check import after every test step and then we'll be good to go

@stuartleeks stuartleeks force-pushed the appinsights-analyticsitems branch from 94e8910 to 8c0869e Compare September 26, 2019 17:57
@stuartleeks
Copy link
Contributor Author

@mbfrahry - thanks for the review. I think I've addressed your comments, but let me know if there's anything I missed!

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the review @stuartleeks! Merging now

@mbfrahry mbfrahry merged commit aa36294 into hashicorp:master Oct 1, 2019
@ghost
Copy link

ghost commented Oct 4, 2019

This has been released in version 1.35.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.35.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants