-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shared Dashboard Resource #4357
Shared Dashboard Resource #4357
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @damoodamoo
Thanks for this PR :)
Taking a look through this mostly LGTM - if we can fix up the minor comments and add import support this otherwise LGTM 👍
Thanks!
Thanks @tombuildsstuff - really helpful comments. I think I've addressed them all now - let me know if anything else is missing. |
Hmmm looks like the build is failing because of the version of the API/SDK i'm using? |
@damoodamoo, it looks like you didn't vendor in the required packages. While we use modules we also vendor them in so we aren't reliant on external sources. Try running |
I also wasn't too sure if I should edit the |
Yep you totally should @damoodamoo 🙂 thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @damoodamoo
Thanks for pushing those changes - I've taken a look through and left a few minor comments inline but this otherwise LGTM 👍
Thanks!
@tombuildsstuff - cheers again - all changes made :) |
This has been released in version 1.35.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.35.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Initial PR for review. References issue #3887 .
Allows azure portal dashboards to be defined and created / updated / destroyed. Example .tf configuration:
Fixes #3887