Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: azurerm_bot_connection #4311

Merged
merged 5 commits into from
Sep 12, 2019
Merged

New Resource: azurerm_bot_connection #4311

merged 5 commits into from
Sep 12, 2019

Conversation

mbfrahry
Copy link
Member 

--- PASS: TestAccAzureRMBotChannelsRegistration (639.35s)
    --- PASS: TestAccAzureRMBotChannelsRegistration/basic (381.55s)
        --- PASS: TestAccAzureRMBotChannelsRegistration/basic/update (163.65s)
        --- PASS: TestAccAzureRMBotChannelsRegistration/basic/complete (122.32s)
        --- PASS: TestAccAzureRMBotChannelsRegistration/basic/basic (95.58s)
    --- PASS: TestAccAzureRMBotChannelsRegistration/coonection (257.80s)
        --- PASS: TestAccAzureRMBotChannelsRegistration/coonection/basic (101.24s)
        --- PASS: TestAccAzureRMBotChannelsRegistration/coonection/complete (156.56s)

@katbyte katbyte added this to the v1.34.0 milestone Sep 12, 2019
katbyte
katbyte approved these changes Sep 12, 2019
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from one question LGTM 👍

azurerm/resource_arm_bot_connection_test.go
ImportStateVerify: true,
ImportStateVerifyIgnore: []string{
"client_secret",
"service_provider_name",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to guess this is not returned by the API?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right!

@mbfrahry mbfrahry requested a review from a team September 12, 2019 20:51
@mbfrahry mbfrahry merged commit 75d6267 into master Sep 12, 2019
@mbfrahry mbfrahry deleted the f-bot-connection branch September 12, 2019 21:02
tombuildsstuff
tombuildsstuff reviewed Sep 13, 2019
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noticed some things whilst 👀 through

website/azurerm.erb Show resolved Hide resolved
website/azurerm.erb Show resolved Hide resolved
website/docs/r/bot_connection.markdown Show resolved Hide resolved
azurerm/resource_arm_bot_connection.go
if props := resp.Properties; props != nil {
d.Set("client_id", props.ClientID)
d.Set("scopes", props.Scopes)
if parameters := props.Parameters; parameters != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove this if check and move it inside of the flatten function - since we should return an empty slice in that case so that parameters is always set into the state

azurerm/resource_arm_bot_channels_registration_test.go Show resolved Hide resolved
@ghost
Copy link

ghost commented Sep 18, 2019

This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.34.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff left review comments

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation new-resource service/bots size/XL
Projects
None yet
Milestone
v1.34.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mbfrahry @tombuildsstuff @katbyte