New Resource: azurerm_marketplace_agreement
#4305
Conversation
| // SupportedResources returns the supported Resources supported by this Service | ||
| func (r Registration) SupportedResources() map[string]*schema.Resource { | ||
| return map[string]*schema.Resource{} | ||
| } |
There was a problem hiding this comment.
whilst I'm aware this file does nothing as-is - I'm intentionally leaving this in to leave the package available
This avoids a circular reference where the resources in the Compute package required access to the common client, which required the client in the Compute package
```
$ ARM_PROVIDER_STRICT=true acctests azurerm TestAccAzureRMMarketplaceAgreement
2019/09/12 12:27:16 [DEBUG] Registering Data Sources for "Compute"..
2019/09/12 12:27:16 [DEBUG] Registering Resources for "Compute"..
=== RUN TestAccAzureRMMarketplaceAgreement
=== RUN TestAccAzureRMMarketplaceAgreement/basic
=== RUN TestAccAzureRMMarketplaceAgreement/basic/basic
=== RUN TestAccAzureRMMarketplaceAgreement/basic/requiresImport
--- PASS: TestAccAzureRMMarketplaceAgreement (145.03s)
--- PASS: TestAccAzureRMMarketplaceAgreement/basic (145.03s)
--- PASS: TestAccAzureRMMarketplaceAgreement/basic/basic (67.86s)
--- PASS: TestAccAzureRMMarketplaceAgreement/basic/requiresImport (77.17s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 145.092s
```
tombuildsstuff
force-pushed
the
f/marketplace-agreement
branch
from
bde5314 to
c91bd13
Compare
|
Tests pass:
|
|
This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.34.0"
}
# ... other configuration ... |
|
I was having similar issue with accepting license agreement while deploying Cisco CSR 1000v with BYOL option. I tried using azurerm_marketplace_agreement but I kept getting following error: Error: compute.VirtualMachinesClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="ResourcePurchaseValidationFailed" Message="User failed validation to purchase resources. Error I was finally able to get around this by going to AWS portal and accepting the license across my entire subscription for programmatic deployment. Once I accepted terms there, terraform executed everything without any issues. Click on get started link displayed on the market place resource page. Want to deploy programmatically? Get started |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
This PR introduces a new resource which allows accepting the license agreement for the specified Marketplace Image.
It also contains some refactoring of the Base Client/Compute Client to be allow us to refactor resources away as needed; and updates the Resource ID Parser to support parsing ID's without a Resource Group
Fixes #1283