Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_eventhub_namespace Added ForceNew property to kafka_enabled setting #4264

Merged
merged 2 commits into from
Sep 6, 2019
Merged

azurerm_eventhub_namespace Added ForceNew property to kafka_enabled setting #4264

merged 2 commits into from
Sep 6, 2019

Conversation

nexxai
Copy link
Contributor

@nexxai nexxai commented Sep 5, 2019

Fixes #4239

@ghost ghost added the size/XS label Sep 5, 2019
@nexxai nexxai mentioned this pull request Sep 5, 2019
Closed
@tombuildsstuff tombuildsstuff added this to the v1.34.0 milestone Sep 6, 2019
tracypholmes
tracypholmes suggested changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@tracypholmes tracypholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nexxai, thanks for the PR! This is looking good. Could you update the documentation to reflect that changing this property now forces a new resource?

@ghost ghost added the documentation label Sep 6, 2019
@nexxai
Copy link
Contributor Author

nexxai commented Sep 6, 2019

@tracypholmes Done

@ghost ghost removed the waiting-response label Sep 6, 2019
tracypholmes
tracypholmes approved these changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@tracypholmes tracypholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you for adding the documentation. LGTM!

@tracypholmes tracypholmes merged commit 2248c20 into hashicorp:master Sep 6, 2019
tracypholmes added a commit that referenced this pull request Sep 6, 2019
@tracypholmes
Updated to include #4264
f22bad0
@ghost
Copy link

ghost commented Sep 18, 2019

This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.34.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tracypholmes tracypholmes tracypholmes approved these changes

Assignees

@tracypholmes tracypholmes

Labels
documentation enhancement service/event-hubs EventHubs size/XS
Projects
None yet
Milestone
v1.34.0
Development

Successfully merging this pull request may close these issues.

Updating Kafka feature for Azure Eventhub Namespace fails
3 participants
@nexxai @tracypholmes @tombuildsstuff