Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add general purpose cognitive service type #4209

Merged
merged 3 commits into from
Sep 2, 2019

Conversation

allantargino
Copy link
Contributor

This PR introduces the new billing model for Cognitive Services, which requires only a single general purpose key for all services.

All Cognitive Services kinds can be listed using:

az cognitiveservices account list-kinds

[
  "AnomalyDetector",
  "Bing.Autosuggest.v7",
  "Bing.CustomSearch",
  "Bing.EntitySearch",
  "Bing.Search.v7",
  "Bing.SpellCheck.v7",
  "CognitiveServices",
  "ComputerVision",
  "ContentModerator",
  "CustomVision.Prediction",
  "CustomVision.Training",
  "Face",
  "ImmersiveReader",
  "InkRecognizer",
  "Internal.AllInOne",
  "LUIS",
  "LUIS.Authoring",
  "Personalizer",
  "QnAMaker",
  "SpeakerRecognition",
  "SpeechServices",
  "TextAnalytics",
  "TextTranslation"
]

The missing kind is CognitiveServices, which this PR proposes to add.

@ghost ghost added the size/XS label Sep 2, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @allantargino, Could we update the docs with the new value? whats thats done this should be good to merge 🙂

@ghost ghost added the documentation label Sep 2, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @allantargino! LGTM now 👍

@katbyte katbyte added this to the v1.34.0 milestone Sep 2, 2019
@katbyte katbyte merged commit 7e3a61b into hashicorp:master Sep 2, 2019
@allantargino
Copy link
Contributor Author

Thank you @katbyte !

@ghost ghost removed the waiting-response label Sep 2, 2019
tombuildsstuff added a commit that referenced this pull request Sep 3, 2019
@ghost
Copy link

ghost commented Sep 18, 2019

This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.34.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Oct 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Oct 3, 2019
@allantargino allantargino deleted the patch-1 branch January 2, 2021 15:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants