Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update resource_arm_mariadb_server.go to support version 10.3 #4170

Merged
merged 2 commits into from
Aug 28, 2019
Merged

Update resource_arm_mariadb_server.go to support version 10.3 #4170

merged 2 commits into from
Aug 28, 2019

Conversation

babinkos
Copy link
Contributor

Add MariaDB version 10.3 to supported version values. Added element "10.3" to slice of strings.

Add MariaDB version 10.3 to supported version values. Added element "10.3" to slice of strings.
@ghost ghost added the size/XS label Aug 28, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @babinkos

Thanks for this PR - taking a look if we can update the documentation then this otherwise LGTM 👍

Thanks!

@@ -123,6 +123,7 @@ func resourceArmMariaDbServer() *schema.Resource {
ForceNew: true,
ValidateFunc: validation.StringInSlice([]string{
"10.2",
"10.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add this to the documentation too? we'd generally phrase that as:

* `version` - (Required) Specifies the version of MariaDB to use. Possible values are `10.2` and `10.3`. Changing this forces a new resource to be created.

@babinkos
Copy link
Contributor Author

babinkos commented Aug 28, 2019 via email

@ghost ghost removed the waiting-response label Aug 28, 2019
Update mariadb_server.html.markdown version possible values to 10.2 and 10.3
@ghost ghost added the documentation label Aug 28, 2019
@babinkos
Copy link
Contributor Author

Hi,
Documentation updated with new MariaDB version values

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @babinkos

@tombuildsstuff tombuildsstuff merged commit 1aacf8e into hashicorp:master Aug 28, 2019
tombuildsstuff added a commit that referenced this pull request Aug 28, 2019
@ghost
Copy link

ghost commented Sep 18, 2019

This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.34.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Sep 27, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants