-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update resource_arm_mariadb_server.go to support version 10.3 #4170
Conversation
Add MariaDB version 10.3 to supported version values. Added element "10.3" to slice of strings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @babinkos
Thanks for this PR - taking a look if we can update the documentation then this otherwise LGTM 👍
Thanks!
@@ -123,6 +123,7 @@ func resourceArmMariaDbServer() *schema.Resource { | |||
ForceNew: true, | |||
ValidateFunc: validation.StringInSlice([]string{ | |||
"10.2", | |||
"10.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add this to the documentation too? we'd generally phrase that as:
* `version` - (Required) Specifies the version of MariaDB to use. Possible values are `10.2` and `10.3`. Changing this forces a new resource to be created.
Hi ,
Yes, looks good !
…On Wed, Aug 28, 2019, 12:29 PM Tom Harvey ***@***.***> wrote:
***@***.**** requested changes on this pull request.
hey @babinkos <https://github.com/babinkos>
Thanks for this PR - taking a look if we can update the documentation then
this otherwise LGTM 👍
Thanks!
------------------------------
In azurerm/resource_arm_mariadb_server.go
<#4170 (comment)>
:
> @@ -123,6 +123,7 @@ func resourceArmMariaDbServer() *schema.Resource {
ForceNew: true,
ValidateFunc: validation.StringInSlice([]string{
"10.2",
+ "10.3",
can we add this to the documentation too
<https://github.com/terraform-providers/terraform-provider-azurerm/blame/master/website/docs/r/mariadb_server.html.markdown#L66>?
we'd generally phrase that as:
* `version` - (Required) Specifies the version of MariaDB to use. Possible values are `10.2` and `10.3`. Changing this forces a new resource to be created.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4170>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJAO2CG3EMEQNU5OOB6VH3DQGZAPZANCNFSM4IQ6YPNQ>
.
|
Update mariadb_server.html.markdown version possible values to 10.2 and 10.3
Hi, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for this @babinkos
This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.34.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Add MariaDB version 10.3 to supported version values. Added element "10.3" to slice of strings.