azurerm_notification_hub_authorization_rule fix to be able to create multiple rules in one go

[andrey-dubnik]

Fixes the issue #4085

[tombuildsstuff]

hey @adubnik

Thanks for this PR :)

Taking a look through whilst this approach may work, it ends up delaying all errors should the input be invalid (or for example the ID being nil).

Instead could we update this to Lock on the name of the Notification Hub (as we do in other resources) - and also add this to the Delete method (since I'm assuming this'll also be an issue there?)

Thanks!

[tombuildsstuff]

@adubnik thanks for pushing those changes

BTW comment on the azureRMLockByName says deprecated, is there something else to use in future?

we're gradually moving those functions (everything in deprecated.go) into azurerm/internal/... - but we don't want to break all the open PR's; as such those exist as a migration point. For the moment it should be fine to use that, when we remove those functions in the near future we'll switch over to the new method, so that should be fine 👍

Thanks!

[tombuildsstuff]

hey @adubnik

Thanks for pushing those changes. Taking a look through aside from one minor typo (which I hope you don't mind, but I'm going to push a commit to fix) this otherwise LGTM 👍

Thanks!

[tombuildsstuff]

Tests pass:

Thanks again @adubnik :)

[ghost]

This has been released in version 1.33.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.33.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!