[resource_arm_function_app] Add missing vnet_name property

[lawrencegripper]

Currently we see an issue where function app deployed with vnet integration enabled is broken on a terraform apply.

This appears to be caused as the tf provider doesn't have a notion of the vnetName property so when it is set elsewhere tf then unwittingly overwrites it when doing an unrelated update as it submits a siteConfig object with vnetName=nil.

This change makes this consistent with the resource_arm_app_service resource which has the property.

By adding this change we can choose to ignore it by adding an ignore or setting it ourselves.

  lifecycle {
    ignore_changes = [
      # Ignore changes to the `site_config` property `virtual_network_name` 
      # as the `webapp_vnet` template updates these keys. 
      site_config.0.virtual_network_name,
    ]
  }

I've added an integration test with passes.

Meta question: Disclaimer I've only done a little bit of research on this ... Does it make sense to have two providers for app_service and function_app as they both use meta.(*ArmClient).web.AppServicesClient but with function_app setting ‘kind=function

https://github.com/lawrencegripper/terraform-provider-azurerm/blob/34cc65f220e9bcef13efc436450f99c39221d71b/azurerm/resource_arm_function_app.go#L272-L280

[katbyte]

Thank you for the PR @lawrencegripper! LGTM 👍

[ghost]

This has been released in version 1.33.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.33.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!