Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to v0.5.0 of github.com/hashicorp/go-azure-helpers #3850

Merged
merged 2 commits into from
Jul 15, 2019

Conversation

tombuildsstuff
Copy link
Contributor

This PR updates to using v0.5.0 of github.com/hashicorp/go-azure-helpers - which exposes one new feature intended to work around a slew of bug reports we're seeing of late. From v0.5.0 when attempting to authenticate using a Service Principal to the Azure CLI - we raise an error stating to use the separate Service Principal authentication method instead. Unfortunately whilst the Azure CLI does expose some of the functionality when authenticated as a Service Principal; not all fields are present and at the moment the error is unhelpful; which is leading to a ton of issues.

When authenticated using the Azure CLI and a Service Principal - we now expose an error with a link to this page explaining how to authenticate using a Service Principal directly.

@tombuildsstuff tombuildsstuff added this to the v1.32.0 milestone Jul 15, 2019
@tombuildsstuff tombuildsstuff requested a review from a team July 15, 2019 11:44
@ghost ghost added the size/S label Jul 15, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit bb61aac into master Jul 15, 2019
@tombuildsstuff tombuildsstuff deleted the f/cli-sp-warning branch July 15, 2019 16:45
tombuildsstuff added a commit that referenced this pull request Jul 15, 2019
@ghost
Copy link

ghost commented Jul 30, 2019

This has been released in version 1.32.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.32.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 15, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants