[azurerm_database_vulnerability_assessment_rule_baseline] New resource for vulnerability scan baseline settings

[benjamin37]

related to #4161

[katbyte]

Hi @benjamin37,

Thank you for this pr. Overall it looks great and i've left some mostly stylistic comments inline that once addressed & the tests pass this should be good to merge.

[benjamin37]

Hi @katbyte,

did some changes you requsted. Still not fixed the panic: Invalid address to set error, why shouldn't I call the set method to set the resource group in the read? This seems to be necessary to me. I will have an other look on this bug tomorrow!

About giving you the rights to push on the branch I will also check back tomorrow.

Kind regards
Benjamin

[katbyte]

@benjamin37, there is a bug on master right now causing acctests to fail.

As for the d.Set(), your right in that it should be required there 🤔 maybe i read the error wrong. Once we fix master we can see if its still there.

[benjamin37]

Hi @katbyte,

thanks for the hint, this saved me some time :-)
I rebased against master again and run all the tests. They seem to work fine now.

Sadly I don't have the permissions to let you push on the branch of this PR.

If there is anything to do on this PR please let me know!

Kind regards
Benjamin

[katbyte]

@benjamin37,

All looks good aside from i am still getting this error:

panic: Invalid address to set: []string{"resource_group_name"}

goroutine 1050 [running]:
github.com/hashicorp/terraform-plugin-sdk/helper/schema.(*ResourceData).Set(0xc0004936c0, 0x506259c, 0x13, 0x49a1b20, 0xc0017fa3a0, 0x0, 0xdf8475800)
	/Users/kt/hashi/tf/azure/azurerm/vendor/github.com/hashicorp/terraform-plugin-sdk/helper/schema/resource_data.go:193 +0x354
github.com/terraform-providers/terraform-provider-azurerm/azurerm.resourceArmMssqlServerSecurityAlertPolicyRead(0xc0004936c0, 0x4a94d80, 0xc00073c400, 0x0, 0x0)
	/Users/kt/hashi/tf/azure/azurerm/azurerm/resource_arm_mssql_server_security_alert_policy.go:169 +0x32d

it looks like your using the wrong read function for the assessment:

(we use an env during tests to make additional checks (export TF_SCHEMA_PANIC_ON_ERROR=1)

[benjamin37]

Hi @katbyte,

ups, that's obviously a bug, I changed it to use the correct read function.

Rebased against master, you can have an other look on the PR.

I've run the tests once again with the TF_SCHEMA_PANIC_ON_ERROR=1 flag. They run without error now.

Kind regards
Benjamin

[katbyte]

Thanks for the revisions @benjamin37! and all your work and patience on this. LGTM now 👍

[ghost]

This has been released in version 1.39.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.39.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!