-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[azurerm_database_vulnerability_assessment_rule_baseline] New resource for vulnerability scan baseline settings #3806
[azurerm_database_vulnerability_assessment_rule_baseline] New resource for vulnerability scan baseline settings #3806
Conversation
…ty_assessment_rule_baseline
…ty-scan-baseline_v1.30.1
…ty-scan-baseline_v1.30.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @benjamin37,
Thank you for this pr. Overall it looks great and i've left some mostly stylistic comments inline that once addressed & the tests pass this should be good to merge.
azurerm/resource_arm_database_vulnerability_assessment_rule_baseline.go
Outdated
Show resolved
Hide resolved
azurerm/resource_arm_database_vulnerability_assessment_rule_baseline.go
Outdated
Show resolved
Hide resolved
azurerm/resource_arm_database_vulnerability_assessment_rule_baseline.go
Outdated
Show resolved
Hide resolved
azurerm/resource_arm_database_vulnerability_assessment_rule_baseline.go
Outdated
Show resolved
Hide resolved
azurerm/resource_arm_database_vulnerability_assessment_rule_baseline.go
Outdated
Show resolved
Hide resolved
azurerm/resource_arm_database_vulnerability_assessment_rule_baseline_test.go
Outdated
Show resolved
Hide resolved
azurerm/resource_arm_database_vulnerability_assessment_rule_baseline_test.go
Outdated
Show resolved
Hide resolved
website/docs/r/database_vulnerability_assessment_rule_baseline.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/database_vulnerability_assessment_rule_baseline.html.markdown
Outdated
Show resolved
Hide resolved
azurerm/resource_arm_database_vulnerability_assessment_rule_baseline.go
Outdated
Show resolved
Hide resolved
azurerm/resource_arm_database_vulnerability_assessment_rule_baseline.go
Outdated
Show resolved
Hide resolved
Co-Authored-By: kt <[email protected]>
Co-Authored-By: kt <[email protected]>
Co-Authored-By: kt <[email protected]>
Co-Authored-By: kt <[email protected]>
Co-Authored-By: kt <[email protected]>
Co-Authored-By: kt <[email protected]>
Co-Authored-By: kt <[email protected]>
Co-Authored-By: kt <[email protected]>
Co-Authored-By: kt <[email protected]>
Co-Authored-By: kt <[email protected]>
…ment of terraform code in tests
…example" as resource name for documentation
…parameters that forces the resource to be recreated
…ility-scan-baseline
Hi @katbyte, did some changes you requsted. Still not fixed the About giving you the rights to push on the branch I will also check back tomorrow. Kind regards |
@benjamin37, there is a bug on master right now causing acctests to fail. As for the |
Hi @katbyte, thanks for the hint, this saved me some time :-) Sadly I don't have the permissions to let you push on the branch of this PR. If there is anything to do on this PR please let me know! Kind regards |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good aside from i am still getting this error:
panic: Invalid address to set: []string{"resource_group_name"}
goroutine 1050 [running]:
github.com/hashicorp/terraform-plugin-sdk/helper/schema.(*ResourceData).Set(0xc0004936c0, 0x506259c, 0x13, 0x49a1b20, 0xc0017fa3a0, 0x0, 0xdf8475800)
/Users/kt/hashi/tf/azure/azurerm/vendor/github.com/hashicorp/terraform-plugin-sdk/helper/schema/resource_data.go:193 +0x354
github.com/terraform-providers/terraform-provider-azurerm/azurerm.resourceArmMssqlServerSecurityAlertPolicyRead(0xc0004936c0, 0x4a94d80, 0xc00073c400, 0x0, 0x0)
/Users/kt/hashi/tf/azure/azurerm/azurerm/resource_arm_mssql_server_security_alert_policy.go:169 +0x32d
it looks like your using the wrong read function for the assessment:
(we use an env during tests to make additional checks (export TF_SCHEMA_PANIC_ON_ERROR=1
)
Hi @katbyte, ups, that's obviously a bug, I changed it to use the correct read function. Rebased against master, you can have an other look on the PR. I've run the tests once again with the Kind regards |
…lity-scan-baseline
…ility-scan-baseline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the revisions @benjamin37! and all your work and patience on this. LGTM now 👍
This has been released in version 1.39.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.39.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
related to #4161