azurerm_storage_account: the account_kind property now supports FileStorage

[MattMencel]

This PR is for adding the FileStorage kind as an option on Storage Accounts.

Description of the FileStorage kind.
https://docs.microsoft.com/en-us/azure/storage/common/storage-account-overview#filestorage-storage-accounts

API Reference: https://docs.microsoft.com/en-us/rest/api/storagerp/storageaccounts/create#kind

(fixes #3756)

[katbyte]

Hi @MattMencel,

Thank you for the PR, it LGTM. however it looks like the test is currently failing:

------- Stdout: -------
=== RUN   TestAccAzureRMStorageAccount_fileStorageWithUpdate
=== PAUSE TestAccAzureRMStorageAccount_fileStorageWithUpdate
=== CONT  TestAccAzureRMStorageAccount_fileStorageWithUpdate
--- FAIL: TestAccAzureRMStorageAccount_fileStorageWithUpdate (72.89s)
    testing.go:568: Step 0 error: errors during apply:
        
        Error: Error creating Azure Storage Account "unlikely23exst2acctifq0": storage.AccountsClient#Create: Failure sending request: StatusCode=400 -- Original Error: Code="InvalidValuesForRequestParameters" Message="Values for request parameters are invalid: kind."
        
          on /opt/teamcity-agent/temp/buildTmp/tf-test639457409/main.tf line 7:
          (source code not available)
        
        
FAIL

[MattMencel]

Hi @katbyte,

The FileStorage kind only works with Premium skus. Looks like the tests pass now.

[katbyte]

fantastic error message from the API! 😅 thanks for the fix.

Looks like there might be another bug in code outside yours thou:

------- Stdout: -------
=== RUN   TestAccAzureRMStorageAccount_fileStorageWithUpdate
=== PAUSE TestAccAzureRMStorageAccount_fileStorageWithUpdate
=== CONT  TestAccAzureRMStorageAccount_fileStorageWithUpdate
--- FAIL: TestAccAzureRMStorageAccount_fileStorageWithUpdate (97.56s)
    testing.go:568: Step 0 error: Check failed: Check 4/4 error: azurerm_storage_account.testsa: Attribute 'access_tier' expected "Hot", got ""
FAIL

i'll take a closer look myself this evening

[katbyte]

Found and fixed the bug @MattMencel 🙂 Hope you don't mind but I pushed up the required change so i could get this merged tonight!

LGTM now 👍

[ghost]

This has been released in version 1.32.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.32.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!