Resource arm analysis services server #3721

r0bnet · 2019-06-24T08:55:56Z

Created this resource as it was requested in an open issue:
#1734
I omitted the gateway_resource_id and backup_blob_container_uri for now as i had problems in testing it (for gateway resource id i'm not even sure for it is needed).

There is also currently no acc test for the admin_users because i'm having difficulties of creating them in the test. Manual tests were successful though.

…ogether

…adjust documentation

# Conflicts: # azurerm/config.go # go.mod # go.sum # vendor/golang.org/x/oauth2/internal/client_appengine.go # vendor/golang.org/x/sys/unix/syscall_aix.go # vendor/golang.org/x/sys/unix/zsyscall_aix_ppc64.go # vendor/golang.org/x/sys/unix/zsyscall_aix_ppc64_gc.go # vendor/golang.org/x/sys/unix/zsyscall_aix_ppc64_gccgo.go # vendor/golang.org/x/sys/unix/zsyscall_linux_arm.go # vendor/golang.org/x/sys/unix/ztypes_linux_386.go # vendor/golang.org/x/sys/unix/ztypes_linux_amd64.go # vendor/golang.org/x/sys/unix/ztypes_linux_arm.go # vendor/golang.org/x/sys/unix/ztypes_linux_arm64.go # vendor/golang.org/x/sys/unix/ztypes_linux_mips.go # vendor/golang.org/x/sys/unix/ztypes_linux_mips64.go # vendor/golang.org/x/sys/unix/ztypes_linux_mips64le.go # vendor/golang.org/x/sys/unix/ztypes_linux_mipsle.go # vendor/golang.org/x/sys/unix/ztypes_linux_ppc64.go # vendor/golang.org/x/sys/unix/ztypes_linux_ppc64le.go # vendor/golang.org/x/sys/unix/ztypes_linux_riscv64.go # vendor/golang.org/x/sys/unix/ztypes_linux_s390x.go # vendor/golang.org/x/sys/unix/ztypes_linux_sparc64.go # vendor/modules.txt

tlaur · 2019-06-24T11:43:58Z

Brilliant, well done on working on this, will take a closer look and take this out for a test spin later.

katbyte

Hi @r0bnet,

Thank you for the new resource. I have left some comments inline. Mostly around the flatten & expand functions.

Additionally there are a few test failures with:

------- Stdout: -------
=== RUN   TestAccAzureRMAnalysisServicesServer_querypoolConnectionMode
=== PAUSE TestAccAzureRMAnalysisServicesServer_querypoolConnectionMode
=== CONT  TestAccAzureRMAnalysisServicesServer_querypoolConnectionMode
--- FAIL: TestAccAzureRMAnalysisServicesServer_querypoolConnectionMode (71.74s)
    testing.go:568: Step 0 error: errors during apply:
        
        Error: Error creating Analysis Services Server "acctestass190626233800983305" (Resource Group "acctestRG-190626233800983305"): analysisservices.ServersClient#Create: Failure sending request: StatusCode=400 -- Original Error: Code="BadRequest" Message="Firewall settings to enable Power BI Service can be  specified only if firewall rules are specified and vice versa." Details=[{"code":"RootActivityId","message":"ad41184d-e2c5-4fd0-afa5-8e2ae3861559"}]
        
          on /opt/teamcity-agent/temp/buildTmp/tf-test004240573/main.tf line 7:
          (source code not available)
        
        
FAIL

azurerm/resource_arm_analysis_services_server.go

katbyte · 2019-06-27T00:23:17Z

azurerm/resource_arm_analysis_services_server.go

+	d.Set("sku", flattenAnalysisServicesServerSku(server.Sku))
+
+	if serverProps := server.ServerProperties; serverProps != nil {
+		d.Set("admin_users", *flattenAnalysisServicesServerAdminUsers(server.AsAdministrators))


Idealy we should be using serverprops instead of server

Also as this is a top level property we shouldn't need a flatten function

Idealy we should be using serverprops instead of server

don't understand completely. Can you go into more detail?

azurerm/resource_arm_analysis_services_server_test.go

r0bnet · 2019-06-27T05:46:19Z

Thanks @katbyte. I currently don't have the possibility to check your annotations but will try to come back to it next week.

rapster83 · 2019-07-13T10:27:43Z

Do you know when the creation of an Azure Analysis Service resource will be part of the next Version? Need this feature for a customer project? Thx

# Conflicts: # azurerm/config.go

fix bug of returning nil

…ver' into resource_arm_analysis_services_server

r0bnet · 2019-07-19T11:09:37Z

So now i fixed the failing test and changed most of the stuff that i was told to.
@stefan-rapp we'll have to wait what the maintainers will say. Sorry for being so late. Hope this will be included in 1.33.0 at least.

rapster83 · 2019-07-19T11:23:31Z

Hi @r0bnet, Nice! Thank you very much. Appreciate it! 👍

tombuildsstuff

hey @r0bnet

Thanks for pushing those changes :)

Taking a look through this mostly LGTM - if we can fix up the minor issues this should otherwise be good to merge 👍

Thanks!

azurerm/resource_arm_analysis_services_server.go

azurerm/resource_arm_analysis_services_server_test.go

r0bnet · 2019-07-19T13:12:22Z

@tombuildsstuff resolved all the issues :)

// unit tests failed because of no response. Can you restart that?

tombuildsstuff · 2019-07-19T16:23:16Z

@r0bnet restarted travis :)

tombuildsstuff

hey @r0bnet

Thanks for pushing those changes - ignoring a couple of minor things (which I hope you don't mind but I'm going to push a commit to fix) this otherwise LGTM 👍

Thanks!

azurerm/resource_arm_analysis_services_server.go

website/docs/r/analysis_services_server.html.markdown

changes have been pushed

tombuildsstuff · 2019-07-22T08:39:31Z

@r0bnet I hope you don't mind but the tests identified an issue so I pushed a commit to fix that; but the tests now pass / this LGTM 👍

ghost · 2019-07-30T03:47:34Z

This has been released in version 1.32.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.32.0"
}
# ... other configuration ...

@kwilczynski

* r/storage_blob: refactoring the existing tests * Updating to use hashicorp#3857 * Add metadata to example usage * r/storage_blob: rewriting the acceptance tests * r/storage_blob: test fixes * Adding a todo * r/private_dns_a_record: fixing comments from code review * Updating to include hashicorp#3847 * Updating to include hashicorp#3849 * Add schedule backup functionality. * Add doc in app_service.html.markdown file * Add deafult value to backup_schedule_enabled * Add default value to backup_schedule_enabled parameter * delete backup-schedule_enabled parameter * Delete backupScheduleEnabled param * Add condition err in resourceArmDeleteScheduleBackup * In deleteConfiguration function delete check * Add HasChange in update function * Fix errcheck in DeleteBackupConfiguration * Frequency interval validation range limit * Delete backupSchedule in create function * Update azurerm/resource_arm_app_service.go Co-Authored-By: Matthew Frahry <[email protected]> * Validate retention period range limit * Fix tabulation and add validate to backup_name * Add frequency_unit validation * azurerm_app_service: fixing the code comments from hashicorp#3330 ``` $ acctests azurerm TestAccAzureRMAppService_backup === RUN TestAccAzureRMAppService_backup === PAUSE TestAccAzureRMAppService_backup === CONT TestAccAzureRMAppService_backup --- PASS: TestAccAzureRMAppService_backup (660.26s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 660.313s ``` ``` $ acctests azurerm TestAccAzureRMAppService_basic === RUN TestAccAzureRMAppService_basic === PAUSE TestAccAzureRMAppService_basic === RUN TestAccAzureRMAppService_basicWindowsContainer === PAUSE TestAccAzureRMAppService_basicWindowsContainer === CONT TestAccAzureRMAppService_basic --- PASS: TestAccAzureRMAppService_basic (189.59s) === CONT TestAccAzureRMAppService_basicWindowsContainer --- PASS: TestAccAzureRMAppService_basicWindowsContainer (369.53s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 559.155s ``` * fwixing comments from code review * Updating to include hashicorp#3804 * [azurerm_recovery_services_protected_vm] - changing `backup_pol… (hashicorp#3822) Refer to hashicorp#3441 now changing the behaviour of backup_policy_id so it should not trigger recreation of resource when value changed (fixes hashicorp#3441) * Update CHANGELOG.md to include hashicorp#3822 * storage: using the environment as available * Fix documentation. Real resource name is azurerm_application_in… (hashicorp#3877) * Fix azurerm_redis_cache non-SSL port in docs * fix merging problem * change firewall test to explicit config fix bug of returning nil * fix some errors; enable adminUsers test but not working currently * fix linting error * fix linting error * fix admin users test * r/storage_share: switching the state migration over to 0.12 format ``` $ go test -v ./azurerm/ -run=TestAzureRMStorageShareMigrateState === RUN TestAzureRMStorageShareMigrateStateV0ToV1 2019/07/19 13:33:46 [DEBUG] Updating ID from "share1" to "share1/group1/account1" 2019/07/19 13:33:46 [DEBUG] Updating ID from "share1" to "share1/group1/account1" 2019/07/19 13:33:46 [DEBUG] Updating ID from "share1" to "share1/group1/account1" 2019/07/19 13:33:46 [DEBUG] Updating ID from "share1" to "share1/group1/account1" --- PASS: TestAzureRMStorageShareMigrateStateV0ToV1 (0.00s) resource_arm_storage_share_migration_test.go:20: [DEBUG] Testing with Cloud "AzureChinaCloud" resource_arm_storage_share_migration_test.go:49: [DEBUG] Ok! resource_arm_storage_share_migration_test.go:20: [DEBUG] Testing with Cloud "AzureGermanCloud" resource_arm_storage_share_migration_test.go:49: [DEBUG] Ok! resource_arm_storage_share_migration_test.go:20: [DEBUG] Testing with Cloud "AzurePublicCloud" resource_arm_storage_share_migration_test.go:49: [DEBUG] Ok! resource_arm_storage_share_migration_test.go:20: [DEBUG] Testing with Cloud "AzureUSGovernmentCloud" resource_arm_storage_share_migration_test.go:49: [DEBUG] Ok! === RUN TestAzureRMStorageShareMigrateStateV1ToV2 2019/07/19 13:33:46 [DEBUG] Updating Resource ID from "share1/group1/account1" to "https://account1.file.core.chinacloudapi.cn/share1" 2019/07/19 13:33:46 [DEBUG] Updating Resource ID from "share1/group1/account1" to "https://account1.file.core.cloudapi.de/share1" 2019/07/19 13:33:46 [DEBUG] Updating Resource ID from "share1/group1/account1" to "https://account1.file.core.windows.net/share1" 2019/07/19 13:33:46 [DEBUG] Updating Resource ID from "share1/group1/account1" to "https://account1.file.core.usgovcloudapi.net/share1" --- PASS: TestAzureRMStorageShareMigrateStateV1ToV2 (0.00s) resource_arm_storage_share_migration_test.go:62: [DEBUG] Testing with Cloud "AzureChinaCloud" resource_arm_storage_share_migration_test.go:91: [DEBUG] Ok! resource_arm_storage_share_migration_test.go:62: [DEBUG] Testing with Cloud "AzureGermanCloud" resource_arm_storage_share_migration_test.go:91: [DEBUG] Ok! resource_arm_storage_share_migration_test.go:62: [DEBUG] Testing with Cloud "AzurePublicCloud" resource_arm_storage_share_migration_test.go:91: [DEBUG] Ok! resource_arm_storage_share_migration_test.go:62: [DEBUG] Testing with Cloud "AzureUSGovernmentCloud" resource_arm_storage_share_migration_test.go:91: [DEBUG] Ok! PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 0.038s ``` * r/kubernetes_cluster: fixing comments from code review * r/kubernetes_cluster: ordering the sections alphabetically * adjust pr comments * r/kubernetes_cluster: switching to an import test * fixing comments from code review * sidebar: fixing the ordering * Updating to include hashicorp#3785 * add function app auth settings * docs * bug: missing link to azurerm_api_management_subscription (hashicorp#3888) * r/analysis_services_server: ensuring the ID is set in the create * updating to include hashicorp#3721 * updating to include hashicorp#3893 * Add auth_settings support to app service slot * Add auth_settings tests to app service slot * auth_settings block in app service slot docs * Missed import modules for test * return value for UpdateAuthSettingsSlot * Wrong resource name in tests * r/app_service_slot: wrapping the errors * r/app_service_slot: renaming the CreateUpdate method to Create since it's been split * r/storage_container: metadata should be computed ``` $ acctests azurerm TestAccAzureRMStorageContainer_metaData === RUN TestAccAzureRMStorageContainer_metaData === PAUSE TestAccAzureRMStorageContainer_metaData === CONT TestAccAzureRMStorageContainer_metaData --- PASS: TestAccAzureRMStorageContainer_metaData (165.53s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 165.571s ``` * [Feature] Azure Maps Account Support Adding Azure Map Accounts support to Terraform. Adds azurerm_maps_account data source. Adds azurerm_maps_account resource type. Adds website documentation for data source and resource. Adds data source and resource acceptance tests. * vendoring the maps sdk * r/maps_account: changes from code review * docs: adding to the sidebar * updating to include hashicorp#3897 * r/maps: removing dead code * d/cosmosdb_account: handling the document endpoint being nil (hashicorp#3899) * maps: making the sku lower-case to match the api * r/storage_container: support for containers named `$web` (hashicorp#3896) Fixes hashicorp#3894 * Update CHANGELOG.md to include hashicorp#3896 * maps: fixing the tests ``` $ acctests azurerm TestAccAzureRMMapsAccount_ === RUN TestAccAzureRMMapsAccount_basic === PAUSE TestAccAzureRMMapsAccount_basic === RUN TestAccAzureRMMapsAccount_sku === PAUSE TestAccAzureRMMapsAccount_sku === RUN TestAccAzureRMMapsAccount_tags === PAUSE TestAccAzureRMMapsAccount_tags === CONT TestAccAzureRMMapsAccount_basic === CONT TestAccAzureRMMapsAccount_tags --- PASS: TestAccAzureRMMapsAccount_basic (80.43s) --- PASS: TestAccAzureRMMapsAccount_tags (111.23s) === CONT TestAccAzureRMMapsAccount_sku --- PASS: TestAccAzureRMMapsAccount_sku (82.26s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 273.956s ``` * [azurerm_kubernetes_cluster ] - support for the `windows_profil… (hashicorp#3519) fixes hashicorp#3508 * Update CHANGELOG.md to include hashicorp#3519 * updating to include hashicorp#3698 * sorting/reordering the changelog * decrease gogc to prevent linting OOM * website: Fix a sidebar name (hashicorp#3911) * `azurerm_storage_account`: set `queue_properties` (hashicorp#3859) * Update CHANGELOG.md * azurerm_cosmosdb_account: validate max_interval_in_seconds and… (hashicorp#3906) fixes hashicorp#3551 * Update CHANGELOG.md to include hashicorp#3906 * kubernetes_cluster: support specifying load balancer sku (hashicorp#3890) Fixes hashicorp#3726 * Update CHANGELOG.md to include hashicorp#3890 * Update mysql_server.html.markdown (hashicorp#3914) * azurerm_application_gateway - Support for Managed Identity (resolves hashicorp#3640) (hashicorp#3648) resolves hashicorp#3640 * Update CHANGELOG.md to include hashicorp#3648 * v1.32.0 * Cleanup after v1.32.0 release * Sending nil certificate when no certificate is specified (hashicorp#3931) * azurerm_kubernetes_cluster - Remove duplicated line in docs (hashicorp#3940) * Bug Fix: `azurerm_api_managment_product` - Additional validation for `approval_required` (hashicorp#3945) * Update CHANGELOG.md * Bug Fix: `azurerm_storage_table` - Migrate id to new format hashicorp#3932 * Bug Fix: `azurerm_kubernetes_cluster` - suppress case difference on `load_balancer_sku` (hashicorp#3958) * Fix crash (hashicorp#3966) * Update CHANGELOG.md * Fix the typo in the application gateway name (hashicorp#3953) The application gateway was referenced by name `test` while it's defined as `network` * azurerm_storage_account - fix `enable_advanced_threat_protectio… (hashicorp#3947) fixes hashicorp#3920 * Update CHANGELOG.md to include hashicorp#3947 * Update CHANGELOG.md * Bug Fix - `azurerm_iot_dps` fix deletion issue with service principal hashicorp#3973 * Update CHANGELOG.md * Update hash function for os_profile_linux_config (hashicorp#3837) * Add new acc test to verify ssh key issue This commit adds a new acceptance test to verify that the vmss is not calculating correctly the hashcode for the `os_profile_linux_config` Related: hashicorp#3836 * Update OsProfileLinuxConfigHash generator Update the `resourceArmVirtualMachineScaleSetOsProfileLinuxConfigHash` method to include in the hash function the fields from the `ssh_keys` subelements. Fixes: hashicorp#3836 * Update CHANGELOG.md to include hashicorp#3837 * Bugfix: Fixes the acceptance tests for resource_arm_dev_test_*_virtual_machine_test.go (hashicorp#3717) * Update CHANGELOG.md to include hashicorp#3717 * azurerm_network_ddos_protection_plan - correctly decodes the re… (hashicorp#3975) Fixes hashicorp#3974 * Update CHANGELOG.md to include hashicorp#3975 * azurerm_virtual_machine_scale_set - changes made to `network… (hashicorp#3821) The acceptance tests added here are describing the issue as reported by this ticket hashicorp#3812 Initially tried to remove the custom Set method which calculates the hashcode similar to what is suggested by hashicorp/terraform#10520 and hashicorp/terraform#15420 but then we got into a position that the test framework was generating a perpetual diff. So the current solution was to include the other fields in the hashcode calculation. Many thanks to @kwilczynski Fixes: hashicorp#3812 Co-authored-by: Krzysztof Wilczynski [email protected] * Update CHANGELOG.md to include hashicorp#3821 * azurerm_postgresql_server - support for version `11.0` (hashicorp#3970) Fixes hashicorp#3969, and relates to hashicorp#3327 even so it doesn't solve the problem for 10.X versions. The Azure SDK for go doesn't provide version 10.7 for example, see here. But fortunately it has a version 11. * Update CHANGELOG.md to include hashicorp#3970 * Update CHANGELOG.md to include hashicorp#3986 * storage: always nil check resource group before deref (hashicorp#3986) * v1.32.1 * Cleanup after v1.32.1 release * Added LogAnalyticsDestinationType * Updated the docs * Added the attribute to the doc * Added the value to the error string * New Resource azurerm_dev_test_lab_schedule - Fix for issue 2334 (hashicorp#3554) This pull request is to fix issue hashicorp#2334, It has changes to add new resource provider **azurerm_dev_test_lab_schedule**. **Additional Points** * Resource provider has been created based on [microsoft.devtestlab/2016-05-15/schedules](https://docs.microsoft.com/en-us/azure/templates/microsoft.devtestlab/2016-05-15/schedules) (fixes hashicorp#2334) * Update CHANGELOG.md to include hashicorp#3554 * Bug Fix: `azurerm_app_service_plan` - workaround for missing error on 404 hashicorp#3990 * Update CHANGELOG.md * Fixing typo (hashicorp#3992) * New Feature: `azrurerm_iot_dps` - add support for `linked_hub` (hashicorp#3922) * Update CHANGELOG.md * azurerm_postgresql_server - remove unsupported version `10.2` (hashicorp#3915) Closes hashicorp#3327 * Update CHANGELOG.md to include hashicorp#3915 * Switch more client registrations to new format (hashicorp#3895) * Added property read and simplified validation * Added check that the log analytics workspace id is provided * Added log_analytics_destination_type to the logAnalyticsWorkspace test * Data source for azurerm_dev_test_virtual_network (hashicorp#3746) * Update CHANGELOG.md to include hashicorp#3554 * azurerm_function_app - support for cors (hashicorp#3949) * Update CHANGELOG.md to include hashicorp#3949 * azurerm_role_definition - enture role_definition_id is correctl… (hashicorp#3913) We encountered the issue where role_definition_id remained nil after create, returning 409s on RoleDefinitionsClient.CreateOrUpdate with code RoleDefinitionWithSameNameExists. Updating role definition resource was failing because resourceArmRoleDefinitionCreateUpdate checks if role_definition_id is nil and, if so, creates a new uuid and calls client.CreateOrUpdate which attempts to create a new resource instead of updating. * Update CHANGELOG.md to include hashicorp#3913 * Updated api_management_api_policy for XML file explanation (hashicorp#3994) Added a note for those seeking to utilize -PolicyFilePath from docs.microsoft.com/en-us/powershell/module/azurerm.apimanagement/set-azurermapimanagementpolicy?view=azurermps-6.13.0#parameters Tested in Azure, this works and would prevent work on implementing PolicyFilePath as another parameter. * `azurerm_traffic_manager_profile` - support for the `interval_… (hashicorp#3473) * Update CHANGELOG.md to include hashicorp#3473 * Migrate more clients to new registration pattern (hashicorp#3999) * azurerm_batch_certificate - fix thumbprint casing in tests (hashicorp#3977) * update CHANGELOG.md to include hashicorp#3977 * Update azurerm/resource_arm_cosmosdb_account.go * Update azurerm/resource_arm_cosmosdb_account.go * quote echo * update echo * change GOGC to 15 * Support for registering Data Sources and Resources from packages * tags: refactoring out to a new package ``` $ go test -v ./azurerm/internal/tags/ === RUN TestExpand --- PASS: TestExpand (0.00s) === RUN TestFilter --- PASS: TestFilter (0.00s) === RUN TestFlatten --- PASS: TestFlatten (0.00s) flatten_test.go:46: [DEBUG] Test "Empty" flatten_test.go:46: [DEBUG] Test "One Item" flatten_test.go:46: [DEBUG] Test "Multiple Items" === RUN TestValidateMaximumNumberOfTags --- PASS: TestValidateMaximumNumberOfTags (0.00s) === RUN TestValidateTagMaxKeyLength --- PASS: TestValidateTagMaxKeyLength (0.00s) === RUN TestValidateTagMaxValueLength --- PASS: TestValidateTagMaxValueLength (0.00s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/tags 0.021s * tags: moving the existing methods to deprecated.go * refactor: moving the top level methods * refactor: moving the networking specific method out * azurerm_analysis_services_server - correct import documentation (server -> servers) (hashicorp#4005) * change GOGC to 20 * Moved test changes to new test TestAccAzureRMMonitorDiagnosticSetting_logAnalyticsWorkspaceDedicated. * Update storage_account.html.markdown * azurerm_container_group - allow empty log_type This is not documented anywhere, as far as I can tell, but if you leave out `logType` when creating the container, you get the behavior of both `ContainerInsights` and `ContainerInstanceLogs` at once. If `logType` is not set, metadata can't be set either. * refactor: moving the validation functions into the validate package * refactor: moving into the deprecated.go * f/service-registration: updating the checklist needed to refactor into packages * azurem_container_group - add a test for unset log_type * fixing the linting * fixing the linting * refactor: moving locks into the internal package * Fix typo in private_dns_a_record docs * provider: add the disable_correlation_request_id option and red… (hashicorp#4023) * resolve conflicts * Add resource_arm_private_dns_cname_record * updating to include hashicorp#4024 * Fix review comments Co-Authored-By: Tom Harvey <[email protected]> * Fix lint issue * dns_zone: deprecatiog the `zone_type` field * updating to include hashicorp#4028 * Update postgresql_server.html.markdown Clarified what geo_redundant_backup means. Source: https://docs.microsoft.com/en-us/azure/postgresql/concepts-backup * updating to include hashicorp#4033 * r/container_group: polling to ensure the NIC is removed from the Network Profile * removing a todo * provider: ensure test logging has date/time * updating to include hashicorp#3716 * r/storage_account: sorting the docs alphabtically * r/storage_account: defaulting the default_action field to 'Allow' * r/storage_account: moving the 'not applicable' text under the top level block definition * provider: misc golang inspection cleanup (hashicorp#4039) * Updating to include hashicorp#4013 * clarification on which API to use (hashicorp#3946) * go get github.com/hashicorp/[email protected]; go mod tidy; go mod vendor; * updating to include hashicorp#4041 * Updating to include hashicorp#4037 * r/monitor_diagnostic_setting: fixing the formatting of the note * updating to include hashicorp#3987 * change graphrabc client registrations to new pattern * change compute client registrations to new pattern * change datalake client registrations to new pattern * change monitor client registrations to new pattern * Update servicebus_subscription_rule.html.markdown (hashicorp#4051) The import example for the subscription filter is incorrect- the resource type is 'azurerm_servicebus_subscription', where it should be 'azurerm_servicebus_subscription_rule' * change network client registrations to new pattern * change resource client registrations to new pattern * change sql client registrations to new pattern * Upped Storage share limit to 100TB; updated docs (hashicorp#4054) * Update CHANGELOG.md to include hashicorp#4054 * I noticed at the top of the page, it still said azurerm_dns_a_record instead of azurerm_private_dns_a_record * Update function_app.html.markdown (hashicorp#4073) * Update function_app.html.markdown I have run into hours of headaches with Azure in particular -- unless some default app settings are specified / seeded within my terraform code. Please include note specified under app settings (and/or something similar). We deploy with Azure DevOps release pipeline, and without these defaults, we cannot successfully deploy to a terraformed function app. * Update function_app.html.markdown * provider: increase linter deadline to 10m (hashicorp#4077) * New Resource: azurerm_mariadb_configuration (hashicorp#4060) * Update to include hashicorp#4060 * [azurerm_role_assignment] Add support for Management Groups (hashicorp#4063) Solves hashicorp#4040 * update CHANGELOG.md to include hashicorp#4063 * [resource_arm_function_app] Add missing vnet_name property (hashicorp#4078) * Update CHANGELOG.md to include hashicorp#4078

ghost · 2019-08-21T14:50:41Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

r0bnet added 18 commits May 21, 2019 08:15

add new analysis services server resource (blocking features commented)

9a4a468

add analysis services server documentation

1ac0a98

comment out blob storage backup uri for now

9b3aadd

rename function to make them distinct

49522c5

add analysis services client registration

2a104c3

add basic acc test for analysis services server

92a8107

add tests for tags and querypool_connection_mode

891e572

add tests for admin_users but can't execute them currently

1f1f466

remove obsolete nil checks

65e20ac

upgrade to v30.0.0 Azure go sdk

db3d3d8

remove unused service fabric files

25346f5

add enable_powerbi_service and firewall rules; fix minor errors

334cb2a

ensure that enable_power_bi_service and ip filter rules will be set t…

0c60eb8

…ogether

add test for firewall rules (not working yet)

a7d8475

rename ipv4_firewall_rules to singular; add test for firewall rules; …

39eec58

…adjust documentation

remove gateway id as i'm currently unsure how to test it (or what it is)

b462958

merge current master

0e3f477

ghost added size/XXL dependencies documentation labels Jun 24, 2019

r0bnet mentioned this pull request Jun 24, 2019

New Resource request: Analysis Services server #1734

Closed

comment unused function out

3965aa6

katbyte previously requested changes Jun 27, 2019

View reviewed changes

katbyte added new-resource service/analysis waiting-response labels Jun 27, 2019

fix github comments on PR

9d3b698

ghost removed the waiting-response label Jul 13, 2019

r0bnet added 8 commits July 19, 2019 08:33

Merge branch 'master' into resource_arm_analysis_services_server

74a2293

# Conflicts: # azurerm/config.go

fix merging problem

fe84342

change firewall test to explicit config

01e300b

fix bug of returning nil

fix some errors; enable adminUsers test but not working currently

46c554e

fix linting error

6e4ae47

fix linting error

60943a1

fix admin users test

c131eed

Merge remote-tracking branch 'fork/resource_arm_analysis_services_ser…

0ee1c9f

…ver' into resource_arm_analysis_services_server

tombuildsstuff added this to the v1.32.0 milestone Jul 19, 2019

tombuildsstuff suggested changes Jul 19, 2019

View reviewed changes

adjust pr comments

d71696e

tombuildsstuff approved these changes Jul 19, 2019

View reviewed changes

azurerm/resource_arm_analysis_services_server.go Outdated Show resolved Hide resolved

website/docs/r/analysis_services_server.html.markdown Show resolved Hide resolved

tombuildsstuff added 2 commits July 19, 2019 18:45

fixing comments from code review

71fd632

sidebar: fixing the ordering

f003cb9

r/analysis_services_server: ensuring the ID is set in the create

7377923

tombuildsstuff merged commit fae9696 into hashicorp:master Jul 22, 2019

tombuildsstuff added a commit that referenced this pull request Jul 22, 2019

updating to include #3721

e1cfceb

r0bnet deleted the resource_arm_analysis_services_server branch July 22, 2019 08:50

ghost locked and limited conversation to collaborators Aug 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Resource arm analysis services server #3721

Resource arm analysis services server #3721

r0bnet commented Jun 24, 2019

tlaur commented Jun 24, 2019

katbyte left a comment

katbyte Jun 27, 2019

katbyte Jun 27, 2019

r0bnet Jul 10, 2019

r0bnet commented Jun 27, 2019

rapster83 commented Jul 13, 2019

r0bnet commented Jul 19, 2019

rapster83 commented Jul 19, 2019

tombuildsstuff left a comment

r0bnet commented Jul 19, 2019 •

edited

Loading

tombuildsstuff commented Jul 19, 2019

tombuildsstuff left a comment

tombuildsstuff commented Jul 22, 2019

ghost commented Jul 30, 2019

ghost commented Aug 21, 2019

Resource arm analysis services server #3721

Resource arm analysis services server #3721

Conversation

r0bnet commented Jun 24, 2019

tlaur commented Jun 24, 2019

katbyte left a comment

Choose a reason for hiding this comment

katbyte Jun 27, 2019

Choose a reason for hiding this comment

katbyte Jun 27, 2019

Choose a reason for hiding this comment

r0bnet Jul 10, 2019

Choose a reason for hiding this comment

r0bnet commented Jun 27, 2019

rapster83 commented Jul 13, 2019

r0bnet commented Jul 19, 2019

rapster83 commented Jul 19, 2019

tombuildsstuff left a comment

Choose a reason for hiding this comment

r0bnet commented Jul 19, 2019 • edited Loading

tombuildsstuff commented Jul 19, 2019

tombuildsstuff left a comment

Choose a reason for hiding this comment

tombuildsstuff commented Jul 22, 2019

ghost commented Jul 30, 2019

ghost commented Aug 21, 2019

r0bnet commented Jul 19, 2019 •

edited

Loading