[azurerm_traffic_manager_endpoint ] - supper for custom_header and subnet properties

[Xiang-ruiqing]

• Be able to add "Subnet Routing Settings" in Azure Traffic Manager Endpoint
• A follow-up for the Subnet Routing method for Azure Traffic Manager
• Can add a list of IP ranges to one endpoint, supporting both CIDR and IP range.

[tombuildsstuff]

hey @Xiang-ruiqing

Thanks for this PR :)

Taking a look through this mostly LGTM - if we can fix up the minor comments then this should otherwise be good to merge 👍

Thanks!

[Xiang-ruiqing]

Fixed.

[Xiang-ruiqing]

Ready to be merged.

[Xiang-ruiqing]

@tombuildsstuff New feature added and waiting for review. Is there anything else need to be done?

[Xiang-ruiqing]

Able to add custom headers and subnets in string lists

[katbyte]

Hi @Xiang-ruiqing,

Thank you for the updates. However i am curious as to why you added the string_header and string_subnet properties. This does not match the API and adds much complexity. Could we revert that change?

Also there are two test failures:

------- Stdout: -------
=== RUN   TestAccAzureRMTrafficManagerEndpoint_updateSubnets
=== PAUSE TestAccAzureRMTrafficManagerEndpoint_updateSubnets
=== CONT  TestAccAzureRMTrafficManagerEndpoint_updateSubnets
--- FAIL: TestAccAzureRMTrafficManagerEndpoint_updateSubnets (104.60s)
    testing.go:568: Step 1 error: Check failed: Check 4/6 error: azurerm_traffic_manager_endpoint.testExternal: Attribute 'subnet.0.first' not found
FAIL

------- Stdout: -------
=== RUN   TestAccAzureRMTrafficManagerEndpoint_updateCustomeHeaders
=== PAUSE TestAccAzureRMTrafficManagerEndpoint_updateCustomeHeaders
=== CONT  TestAccAzureRMTrafficManagerEndpoint_updateCustomeHeaders
--- FAIL: TestAccAzureRMTrafficManagerEndpoint_updateCustomeHeaders (73.02s)
    testing.go:568: Step 0 error: errors during apply:
        
        Error: trafficmanager.EndpointsClient#CreateOrUpdate: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="BadRequest" Message="Address ranges are blank or global for multiple endpoints: acctestend-external190624231009075719, acctestend-external190624231009075719-2. Only one endpoint in a subnet profile may have a blank or global subnet list."
        
          on /opt/teamcity-agent/temp/buildTmp/tf-test266657800/main.tf line 36:
          (source code not available)
        
        
FAIL

[Xiang-ruiqing]

@katbyte The commits are rebased and Test error fixed.

[Xiang-ruiqing]

@tombuildsstuff @katbyte

[katbyte]

Thank you for the revisions @Xiang-ruiqing,

I've given this a more detailed review and left some more comments inline mostly around validation and style. Once those have been addressed (and the tests pass) this should be good to merge 🙂

[Xiang-ruiqing]

@katbyte
Thank you for your time in giving me these suggestions.
I am in summer internship and this PR is part of my project, so if OK, could you merge it?
Therefore, I may finish this project by saying it is in production.

[Xiang-ruiqing]

@katbyte @tombuildsstuff

[katbyte]

Thanks for the revisions @Xiang-ruiqing, LGTM now 👍

[Xiang-ruiqing]

Thank you a lot.

[ghost]

This has been released in version 1.32.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.32.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!