Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_iot_dps #3618

Merged
merged 3 commits into from
Jun 10, 2019
Merged

New Resource: azurerm_iot_dps #3618

merged 3 commits into from
Jun 10, 2019

Conversation

mbfrahry
Copy link
Member

@mbfrahry mbfrahry commented Jun 8, 2019

Start of #1712. The other pieces of that issue will be separate resources

--- PASS: TestAccAzureRMIotDPS_update (277.78s)
--- PASS: TestAccAzureRMIotDPS_basic (373.70s)

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from one minor comment LGTM 👍


sku {
name = "S1"
tier = "Standard"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tier = "Standard"
tier = "Standard"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this one. This change changes the spaces from 4 to 3

@mbfrahry mbfrahry merged commit 8e1343c into master Jun 10, 2019
@mbfrahry mbfrahry deleted the f-iotdps branch June 10, 2019 14:33
@katbyte katbyte modified the milestones: Future, v1.31.0 Jun 13, 2019
@ghost
Copy link

ghost commented Jun 28, 2019

This has been released in version 1.31.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.31.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jul 10, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants