-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider/azurerm: Add maximum_elastic_worker_count to app_service_plan #3547
provider/azurerm: Add maximum_elastic_worker_count to app_service_plan #3547
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @stack72,
Thank you for the PR. I've left some comments inline, with the most important one being adding this property to some tests.
d66f246
to
83dc8d0
Compare
Hi @katbyte, do you have any thoughts on what validation you want added in the question above? I'd love to get this PR finished up :) |
83dc8d0
to
0f66fd7
Compare
@katbyte / @tombuildsstuff so I looked into what Validation was available. The API does have no mention of it: No does the SDK. I believe this is ready for review again |
0f66fd7
to
1d36cfa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @stack72
Thanks for pushing those changes - besides one minor markdown thing to fix (which I'm going to push a commit to fix) this LGTM 👍
Thanks!
|
||
* `is_xenon` - A flag that indicates if it's a xenon plan (support for Windows Container) | ||
|
||
* `maximum_number_of_workers` - The maximum number of workers supported with the App Service Plan's sku. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to not break the formatting, can we make this:
* `maximum_number_of_workers` - The maximum number of workers supported with the App Service Plan's sku. | |
* `maximum_number_of_workers` - The maximum number of workers supported with the App Service Plan's sku. | |
dismissing since changes have been pushed
This has been released in version 1.30.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.30.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
@tombuildsstuff so I didn't add this to the
deprecated
properties block and went with the new way ofmaximum_number_of_workers
Fixes: #3445