Added validation for firewall subnet name and forced new resource on change in subnet ID

[jackofallops]

fixes #3299

[tombuildsstuff]

hey @sjones-sot

Thanks for this PR :)

Taking a look through this mostly LGTM, if we can switch over to using the parseAzureResourceID function (to ensure this is valid too) - then we should be able to get this merged 👍

Thanks!

[tombuildsstuff]

Ignoring some unrelated test failures - the tests pass:

[tombuildsstuff]

hey @sjones-sot

Thanks for pushing those changes - this now LGTM 👍

[ghost]

This has been released in version 1.28.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.28.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!