Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable correlation request ID header in ARM API. #3253

Merged
merged 1 commit into from
May 22, 2019

Conversation

metacpp
Copy link
Contributor

@metacpp metacpp commented Apr 16, 2019

This PR is created to pass unique client generated correlation request id to HTTP extension header, x-ms-correlation-request-id, which can be used to correlate different ARM HTTP requests from same client session.

@ghost ghost added the size/M label Apr 16, 2019
@metacpp metacpp requested review from paultyng and JunyiYi April 16, 2019 01:51
@paultyng
Copy link
Contributor

We should hold merging this until 1.25 ships.

@katbyte katbyte added this to the v1.27 milestone Apr 16, 2019
@tombuildsstuff tombuildsstuff modified the milestones: v1.28.0, v1.29.0 May 7, 2019
@tombuildsstuff tombuildsstuff merged commit 84a8390 into master May 22, 2019
@tombuildsstuff tombuildsstuff deleted the correlationID branch May 22, 2019 10:39
tombuildsstuff added a commit that referenced this pull request May 22, 2019
@ghost
Copy link

ghost commented May 26, 2019

This has been released in version 1.29.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.29.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 21, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants