Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New data source 'azurerm_firewall' #3235

Merged
merged 5 commits into from
Apr 11, 2019
Merged

Conversation

tiwood
Copy link
Contributor

@tiwood tiwood commented Apr 11, 2019

This introduces a new data source azurerm_firewall

This is mostly a cc of the corresponding resource.

  • New data source azurerm_firewall
  • Tests
  • Documentation

Usage

data "azurerm_firewall" "test" {
  name                = "firewall1"
  resource_group_name = "firewall-RG"
}

output "firewall_private_ip" {
  value = "${data.azurerm_firewall.test.ip_configuration.0.private_ip_address}"
}

@ghost ghost added the size/L label Apr 11, 2019
@ghost ghost added the documentation label Apr 11, 2019
@tiwood tiwood marked this pull request as ready for review April 11, 2019 18:14
@tiwood
Copy link
Contributor Author

tiwood commented Apr 11, 2019

Tests pass.

TF_ACC=1 go test $(go list ./... |grep -v 'vendor'|grep -v 'examples') -v -run=TestAccDataSourceAzureRMFirewall* -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
?   	github.com/terraform-providers/terraform-provider-azurerm	[no test files]
=== RUN   TestAccDataSourceAzureRMFirewall_basic
=== PAUSE TestAccDataSourceAzureRMFirewall_basic
=== CONT  TestAccDataSourceAzureRMFirewall_basic
--- PASS: TestAccDataSourceAzureRMFirewall_basic (1011.45s)
PASS

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @tiwood!

LGTM 👍

@katbyte katbyte added this to the v1.25.0 milestone Apr 11, 2019
@katbyte katbyte merged commit 7c649ef into hashicorp:master Apr 11, 2019
katbyte added a commit that referenced this pull request Apr 11, 2019
@ghost
Copy link

ghost commented Apr 17, 2019

This has been released in version 1.25.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.25.0"
}
# ... other configuration ...

@tiwood tiwood deleted the ds_firewall branch May 8, 2019 06:37
@ghost
Copy link

ghost commented May 12, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants