Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Trafficmanager Routing Methods #3207

Merged
merged 2 commits into from
Apr 8, 2019

Conversation

Lucretius
Copy link
Contributor

Resolves #2966

I've gone and bumped the trafficmanager SDK to the version mentioned in the PR. make test ran just fine, we will see how the acceptance tests perform.

The PR mentioned two new routing methods (which are Subnet and MultiValue); I've added the option to set them both.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lucretius,

Thanks for the PR, aside from one minor comment this LGTM 👍

Hope you dont' mind but i am going to push a change so i can get it merged 🙂

@@ -69,6 +69,8 @@ The following arguments are supported:
- `Performance` - Traffic is routed via the User's closest Endpoint
- `Weighted` - Traffic is spread across Endpoints proportional to their `weight` value.
- `Priority` - Traffic is routed to the Endpoint with the lowest `priority` value.
- `MultiValue`- All healthy Endpoints are returned. MultiValue routing method works only if all the endpoints of type ‘External’ and are specified as IPv4 or IPv6 addresses.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should probably be alphabetically sorted

@katbyte katbyte added this to the v1.25.0 milestone Apr 8, 2019
@katbyte katbyte merged commit 0f7e89e into hashicorp:master Apr 8, 2019
katbyte added a commit that referenced this pull request Apr 8, 2019
@ghost
Copy link

ghost commented Apr 17, 2019

This has been released in version 1.25.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.25.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 9, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure Traffic Manager: 'Subnet' Traffic Routing Method Support
2 participants