-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Trafficmanager Routing Methods #3207
Add new Trafficmanager Routing Methods #3207
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, aside from one minor comment this LGTM 👍
Hope you dont' mind but i am going to push a change so i can get it merged 🙂
@@ -69,6 +69,8 @@ The following arguments are supported: | |||
- `Performance` - Traffic is routed via the User's closest Endpoint | |||
- `Weighted` - Traffic is spread across Endpoints proportional to their `weight` value. | |||
- `Priority` - Traffic is routed to the Endpoint with the lowest `priority` value. | |||
- `MultiValue`- All healthy Endpoints are returned. MultiValue routing method works only if all the endpoints of type ‘External’ and are specified as IPv4 or IPv6 addresses. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should probably be alphabetically sorted
This has been released in version 1.25.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.25.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Resolves #2966
I've gone and bumped the trafficmanager SDK to the version mentioned in the PR.
make test
ran just fine, we will see how the acceptance tests perform.The PR mentioned two new routing methods (which are
Subnet
andMultiValue
); I've added the option to set them both.