Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional app service scm types #3019

Merged
merged 6 commits into from
Mar 15, 2019

Conversation

hbuckle
Copy link
Contributor

@hbuckle hbuckle commented Mar 7, 2019

Update scm_type validation with additional providers

@ghost ghost added the size/XS label Mar 7, 2019
@tombuildsstuff
Copy link
Contributor

hey @hbuckle

Thanks for this PR :)

Whilst the code for this looks fine - would it be possible to update the documentation for app_service to include these new values?

Thanks!

@ghost ghost added the documentation label Mar 7, 2019
@ghost ghost added size/S and removed size/XS labels Mar 7, 2019
@hbuckle
Copy link
Contributor Author

hbuckle commented Mar 7, 2019

@tombuildsstuff - docs updated. I added VSTSRM as well, as that gets added by Azure Pipelines even though it isn't in the specs.

@ghost ghost removed the waiting-response label Mar 7, 2019
@tombuildsstuff tombuildsstuff modified the milestones: 1.25.0, v1.25.0, v1.24.0 Mar 8, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @hbuckle

Thanks for pushing those updates - I've left a couple of comments which I'm going to push a commit for but this otherwise LGTM 👍

Thanks!

website/docs/r/app_service.html.markdown Outdated Show resolved Hide resolved
azurerm/helpers/azure/app_service.go Show resolved Hide resolved
@tombuildsstuff tombuildsstuff merged commit bbe42ee into hashicorp:master Mar 15, 2019
tombuildsstuff added a commit that referenced this pull request Mar 15, 2019
@ghost
Copy link

ghost commented Apr 3, 2019

This has been released in version 1.24.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.24.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 14, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants