Add option in IoTHub to Enable Fallback Route

[BlueBasher]

Added the option to specify if the IoTHub fallback route should be enabled or not.
It defaults to enabled since the Azure Portal, CLI or ARM all default to true. This is a change in the behaviour of Terraform since Terraform used to default to disabled.
See also issue #2719

PS. apologies for the multiple commits, first time Go developer and couldn't get the build to run locally.

[katbyte]

Hi @BlueBasher,

Thank you for the PR, don't worry about the commits I'll squash on merge 🙂 the main things this PR needs is a test and updating the documentation with the new property.

I also question if we shouldn't be exposing the other properties here with those values as defaults? WDYU

[BlueBasher]

Hi @katbyte,
FYI: I've finished the changes you requested in the review.

[katbyte]

Hi @BlueBasher,

Thanks for the updates, i've gone over it once more, most of the comments are pretty minor with the main blocker being the missing nil check.

[maxbog]

@katbyte, @BlueBasher Hi, I am very interested in this PR, will this be included in 1.23.0? Do you need any help with moving it forward?

[katbyte]

Hi @maxbog, @BlueBasher,

I am hoping to have it included in 1.23, right now the only thing holding it up is the tests don't pass:

multiple:

------- Stdout: -------
=== RUN   TestAccAzureRMIotHubConsumerGroup_operationsMonitoringEvents
=== PAUSE TestAccAzureRMIotHubConsumerGroup_operationsMonitoringEvents
=== CONT  TestAccAzureRMIotHubConsumerGroup_operationsMonitoringEvents
--- FAIL: TestAccAzureRMIotHubConsumerGroup_operationsMonitoringEvents (334.78s)
    testing.go:538: Step 0 error: After applying this step, the plan was not empty:
        
        DIFF:
        
        UPDATE: azurerm_iothub.test
          fallback_route.#: "1" => "0"

[katbyte]

As well as:

--- FAIL: TestAccAzureRMIotHub_fallbackRoute (62.55s)
    testing.go:538: Step 0 error: Error applying: 1 error occurred:
        	* azurerm_iothub.test: 1 error occurred:
        	* azurerm_iothub.test: Error creating/updating IotHub "acctestIoTHub-190218234111779608" (Resource Group "acctestRG-190218234111779608"): devices.IotHubResourceClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="Failed" Message="The async operation failed." InnerError={"unmarshalError":"json: cannot unmarshal number into Go struct field serviceError2.code of type string"} AdditionalInfo=[{"code":400108,"httpStatusCode":"BadRequest","message":"EndpointName:fallback is not from a valid type. If you contact a support representative please include this correlation identifier: ede0b60b-e576-456b-8896-c12b7b75a936, timestamp: 2019-02-19 07:41:21Z, errorcode: IH400108."}]

Looks like the API may have changed 🤔

[katbyte]

@BlueBasher,

I hope you don't mind but i pushed an update to fix the non-empty plan failure. Opted to ignore the default fallback route, another option would be to mark those properties as computed but i'm not sure it makes sense. WDYT?

[BlueBasher]

@katbyte
Definitely don't mind, most important thing is we get the functionality merged :)
Your change looks fine to me, think ignoring the default is the best option.

Do we need anymore change now? Or does this also fix the AccTest?

[katbyte]

@BlueBasher,

I spent some more time trying to figure out why it was 400'ing: updated the API and removed name (it doesn't seem to actually do anything if you set it?) and did a create then update that finally got rid of the 400.

However now it doesn't seem to be actually setting enabled to true so i am going to push what i have for now and pick this up later in the week.

[maxbog]

I don't really see the point of this diff.
When I removed it and set the Properties.Routing.FallbackRoute property to fallbackRoute in the line above, fallback routes started working

[maxbog]

@katbyte, @BlueBasher I made some minor modifications to make the code work, please look at my comments

[maxbog]

For the test to pass, this is needed

Suggested change

	endpoint_names = ["fallback"]
	endpoint_names = ["events"]

[katbyte]

Well that was it! thanks

[katbyte]

Thank you very much for pointing us in the right direction @maxbog! tests pass and this LGTM now. Will merge it shortly @BlueBasher

[BlueBasher]

@katbyte @maxbog Thanks for all the help to get this merged!

[ghost]

This has been released in version 1.23.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.23.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!