Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover all subnet properties during VNet update #2738

Merged
merged 2 commits into from
Jan 25, 2019

Conversation

JunyiYi
Copy link

@JunyiYi JunyiYi commented Jan 22, 2019

This PR fixes #1619 . To prevent future changes, it also covers all other properties by returning the response directly instead of copying the fields one-by-one.

@ghost ghost added the size/M label Jan 22, 2019
@JunyiYi
Copy link
Author

JunyiYi commented Jan 23, 2019

Tests (including all vnet related tests as well as subnet tests) passed:
image

Copy link
Contributor

@metacpp metacpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JunyiYi Thanks for the fix and it LGTM.

@katbyte
Copy link
Collaborator

katbyte commented Jan 25, 2019

Thanks for the fix @JunyiYi, LGTM and tests pass:

OK	TestAccAzureRMSubnet_routeTableUpdate 	4m:06s,622ms 	14
OK	TestAccAzureRMSubnet_routeTableRemove 	3m:55s,018ms 	13
OK	TestAccAzureRMSubnet_basic 	3m:53s,808ms 	12
OK	TestAccAzureRMSubnet_serviceEndpointsVNetUpdate 	3m:53s,522ms 	11
OK	TestAccAzureRMSubnetNetworkSecurityGroupAssociation_deleted 	3m:52s,431ms 	10
OK	TestAccAzureRMSubnet_bug7986 	3m:49s,405ms 	9
OK	TestAccAzureRMSubnet_removeNetworkSecurityGroup 	3m:47s,508ms 	8
OK	TestAccAzureRMSubnet_bug15204 	3m:45s,122ms 	7
OK	TestAccAzureRMSubnetNetworkSecurityGroupAssociation_basic 	3m:41s,959ms 	6
OK	TestAccAzureRMSubnetRouteTableAssociation_basic 	3m:39s,716ms 	5
OK	TestAccAzureRMSubnet_disappears 	3m:33s,881ms 	4
OK	TestAccAzureRMSubnet_serviceEndpoints 	3m:32s,419ms 	3
OK	TestAccAzureRMSubnet_delegation 	3m:27s,983ms 	2
OK	TestAccAzureRMSubnetRouteTableAssociation_deleted 	3m:26s,674ms 	1

@katbyte katbyte merged commit 82cb3d8 into master Jan 25, 2019
@katbyte katbyte deleted the vnetupdate_subnetsvcendpoint branch January 25, 2019 02:34
katbyte added a commit that referenced this pull request Jan 25, 2019
@tombuildsstuff tombuildsstuff modified the milestones: 2.0.0, 1.22.0 Jan 25, 2019
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_subnet removes Microsoft.Storage service_endpoints after changes to VNet
4 participants