Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_cosmosdb_account: allow an empty value for ip filter property #2713

Merged
merged 1 commit into from
Jan 18, 2019
Merged

azurerm_cosmosdb_account: allow an empty value for ip filter property #2713

merged 1 commit into from
Jan 18, 2019

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Jan 18, 2019 •
edited
Loading

fixes #2700

==> Fixing source code with gofmt...
gofmt -s -w ./azurerm
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -test.run=TestAccAzureRMCosmosDBAccount_emptyIpFilter -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMCosmosDBAccount_emptyIpFilter
=== PAUSE TestAccAzureRMCosmosDBAccount_emptyIpFilter
=== CONT  TestAccAzureRMCosmosDBAccount_emptyIpFilter
--- PASS: TestAccAzureRMCosmosDBAccount_emptyIpFilter (2054.55s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	2056.353s

@katbyte katbyte added this to the 2.0.0 milestone Jan 18, 2019
@katbyte katbyte requested a review from a team January 18, 2019 08:47
@ghost ghost added the size/S label Jan 18, 2019
@katbyte katbyte mentioned this pull request Jan 18, 2019
Closed
tombuildsstuff
tombuildsstuff approved these changes Jan 18, 2019
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 (although we need to rewrite all the acctests in that file at some point imo)

@katbyte katbyte merged commit 9175c6c into master Jan 18, 2019
@katbyte katbyte deleted the cosmis/empty_ip_ilter branch January 18, 2019 21:14
katbyte added a commit that referenced this pull request Jan 18, 2019
@katbyte
Update CHANGELOG.md to include #2713
934c1ab
@tombuildsstuff tombuildsstuff modified the milestones: 2.0.0, 1.22.0 Jan 21, 2019
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
bug service/cosmosdb size/S
Projects
None yet
Milestone
v1.22.0
Development

Successfully merging this pull request may close these issues.

azurerm_cosmosdb_account ip_range_filter can't be "" when try to skip
2 participants
@katbyte @tombuildsstuff