Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/notification_hub_namespace: polling to handle eventual consistency #2701

Merged
merged 2 commits into from
Jan 17, 2019
Merged

r/notification_hub_namespace: polling to handle eventual consistency #2701

merged 2 commits into from
Jan 17, 2019

Conversation

tombuildsstuff
Copy link
Contributor

Seems to fix the issue raised in #1822:

$ acctests azurerm TestAccAzureRMNotificationHub_
=== RUN   TestAccAzureRMNotificationHub_basic
=== PAUSE TestAccAzureRMNotificationHub_basic
=== CONT  TestAccAzureRMNotificationHub_basic
--- PASS: TestAccAzureRMNotificationHub_basic (341.71s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	343.183s

12:53 $ acctests azurerm TestAccAzureRMNotificationHub_
=== RUN   TestAccAzureRMNotificationHub_basic
=== PAUSE TestAccAzureRMNotificationHub_basic
=== CONT  TestAccAzureRMNotificationHub_basic
--- PASS: TestAccAzureRMNotificationHub_basic (343.42s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	343.987s

12:59 $ acctests azurerm TestAccAzureRMNotificationHub_
=== RUN   TestAccAzureRMNotificationHub_basic
=== PAUSE TestAccAzureRMNotificationHub_basic
=== CONT  TestAccAzureRMNotificationHub_basic
--- PASS: TestAccAzureRMNotificationHub_basic (345.83s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	346.334s

Fixes #1822

@tombuildsstuff tombuildsstuff added this to the 2.0.0 milestone Jan 17, 2019
@ghost ghost added the size/M label Jan 17, 2019
@tombuildsstuff tombuildsstuff requested a review from a team January 17, 2019 12:09
katbyte
katbyte approved these changes Jan 17, 2019
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@katbyte katbyte merged commit 0af1119 into master Jan 17, 2019
@katbyte katbyte deleted the b/notification-hub-eventual-consistency branch January 17, 2019 19:24
katbyte added a commit that referenced this pull request Jan 17, 2019
@katbyte
Update CHANGELOG.md to include #2701
acc815a
@tombuildsstuff tombuildsstuff modified the milestones: 2.0.0, 1.22.0 Jan 21, 2019
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
bug service/notifications size/M
Projects
None yet
Milestone
v1.22.0
Development

Successfully merging this pull request may close these issues.

'azurerm_notification_hub' can't find hub_namespace sometimes in serial creation.
2 participants
@tombuildsstuff @katbyte