-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update azure-go-sdk to v24.0.0 and autorest to v11.2.0 #2572
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
providing the tests pass, aside from the one comment this otherwise LGTM; I think we'll also want to update this in github.com/hashicorp/go-azure-helpers too (since we'll be switching to Go Modules in the near future)
@katbyte taking a look through the tests, it appears this also requires a downgrade of the Monitor Action Group SDK / API:
other than that the tests look alright 👍 |
So it seems the new version of the SDK isn't calling the correct API. Its currently using
Opened a ticket on the SDK |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
azure-go-sdk
v24.0.0
requires an autorest tracing package that was added inv11.2.0