Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azure-go-sdk to v24.0.0 and autorest to v11.2.0 #2572

Merged
merged 6 commits into from
Jan 8, 2019
Merged

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Dec 25, 2018

azure-go-sdk v24.0.0 requires an autorest tracing package that was added in v11.2.0

@ghost ghost added the size/XXL label Dec 25, 2018
@katbyte katbyte added this to the 1.21.0 milestone Dec 26, 2018
@katbyte katbyte changed the title [WIP] Update azure-go-sdk to version 24.0.0 Update azure-go-sdk to version v24.0.0 and autorest to v11.2.0 Dec 27, 2018
@katbyte katbyte changed the title Update azure-go-sdk to version v24.0.0 and autorest to v11.2.0 Update azure-go-sdk to v24.0.0 and autorest to v11.2.0 Dec 27, 2018
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

providing the tests pass, aside from the one comment this otherwise LGTM; I think we'll also want to update this in github.com/hashicorp/go-azure-helpers too (since we'll be switching to Go Modules in the near future)

azurerm/resource_arm_express_route_circuit.go Show resolved Hide resolved
@tombuildsstuff
Copy link
Contributor

@katbyte taking a look through the tests, it appears this also requires a downgrade of the Monitor Action Group SDK / API:

* azurerm_monitor_action_group.test: Error creating or updating action group "acctestActionGroup-7372559643033914044" (resource group "acctestRG-7372559643033914044"): insights.ActionGroupsClient#CreateOrUpdate: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="NoRegisteredProviderFound" Message="No registered resource provider found for location 'global' and API version '2018-09-01' for type 'actiongroups'. The supported api-versions are '2017-03-01-preview, 2017-04-01, 2018-03-01'. The supported locations are 'global'."

other than that the tests look alright 👍

@katbyte
Copy link
Collaborator Author

katbyte commented Dec 29, 2018

So it seems the new version of the SDK isn't calling the correct API. Its currently using 2018-03-01, from the available:

[16:57:07] kt@snowbook:~/hashi/go/src/github.com/Azure/azure-sdk-for-go▸v24$ find . -type d | egrep \/insights\/
./profiles/latest/appinsights/mgmt/insights/insightsapi
./profiles/preview/appinsights/mgmt/insights/insightsapi
./profiles/preview/preview/monitor/mgmt/insights/insightsapi
./profiles/preview/preview/appinsights/insights/insightsapi
./services/appinsights/mgmt/2015-05-01/insights/insightsapi
./services/preview/monitor/mgmt/2018-09-01/insights/insightsapi
./services/preview/monitor/mgmt/2017-05-01-preview/insights/insightsapi
./services/preview/monitor/mgmt/2018-03-01/insights/insightsapi
./services/preview/appinsights/v1/insights/insightsapi

2018-03-01 is giving the error, 2018-09-01 gives the same error, and 2017-05-01-preview lacks a client we now use.

Opened a ticket on the SDK

@katbyte katbyte added upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR and removed waiting-response labels Dec 29, 2018
@katbyte katbyte modified the milestones: 1.21.0, Blocked Dec 29, 2018
@katbyte katbyte merged commit 5ef2b53 into master Jan 8, 2019
@katbyte katbyte deleted the dep/sdk-24 branch January 8, 2019 23:47
katbyte added a commit that referenced this pull request Jan 8, 2019
@katbyte katbyte modified the milestones: Blocked, 1.21.0 Jan 8, 2019
@katbyte katbyte removed the upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR label Jan 8, 2019
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants