Force recreation if storage_data_disk.creation_option changes (#218) #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azure Resource Manager API doesn't support changes to this field. It should recreate the virtual machine and attach the disks again. module.xpto.azurerm_virtual_machine.prometheus_virtual_machine: Modifying... (ID: /subscriptions/xxxxx...ute/virtualMachines/vm) delete_data_disks_on_termination: "" => "false" delete_os_disk_on_termination: "" => "true" storage_data_disk.0.create_option: "Empty" => "Attach" storage_data_disk.1.create_option: "Empty" => "Attach" tags.%: "0" => "1" tags.role: "" => "xpto" Error applying plan: 1 error(s) occurred: * module.xpto.azurerm_virtual_machine.vm: 1 error(s) occurred: * azurerm_virtual_machine.prometheus_virtual_machine: compute.VirtualMachinesClient#CreateOrUpdate: Failure responding to request: StatusCode=409 -- Original Error: autorest/azure: Service returned an error. Status=409 Code="PropertyChangeNotAllowed" Message="Changing property 'dataDisk.createOption' is not allowed."
|
Tests pass: |
radeksimko
approved these changes
Aug 11, 2017
| Config: postConfig, | ||
| Check: resource.ComposeTestCheckFunc( | ||
| testCheckAzureRMVirtualMachineExists("azurerm_virtual_machine.test", &afterUpdate), | ||
| testAccCheckVirtualMachineRecreated(t, &afterCreate, &afterUpdate), |
There was a problem hiding this comment.
I think we should add a state check for the field that's being patched in this PR, just for sanity...
|
Updated tests: |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-opening #218
Rebased and added a commit to the end of #218 which apparently closed the original PR - re-opening this here
Original issue body from #218:
I'm not sure how to test this change, please provide any feedback to help me with it.
Azure Resource Manager API doesn't support changes to this field. It
should recreate the virtual machine and attach the disks again.
Actual Behaviour:
module.xpto.azurerm_virtual_machine.prometheus_virtual_machine:
Modifying... (ID: /subscriptions/xxxxx...ute/virtualMachines/vm)
delete_data_disks_on_termination: "" => "false"
delete_os_disk_on_termination: "" => "true"
storage_data_disk.0.create_option: "Empty" => "Attach"
storage_data_disk.1.create_option: "Empty" => "Attach"
tags.%: "0" => "1"
tags.role: "" => "xpto"
Error applying plan:
1 error(s) occurred:
module.xpto.azurerm_virtual_machine.vm: 1 error(s) occurred:
azurerm_virtual_machine.prometheus_virtual_machine:
compute.VirtualMachinesClient#CreateOrUpdate: Failure responding to
request: StatusCode=409 -- Original Error: autorest/azure: Service
returned an error. Status=409 Code="PropertyChangeNotAllowed"
Message="Changing property 'dataDisk.createOption' is not allowed."