Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authentication: switching to use Azure CLI Token Authentication #2387

Merged
merged 4 commits into from
Nov 27, 2018

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Nov 26, 2018

This PR updates the Azure CLI authentication such that rather than parsing the Access Tokens out of the Azure CLI credentials files

This also wants a review of the docs to ensure they mention using Azure CLI v2 rather than v1

This fixes #502

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit 8222b4b into master Nov 27, 2018
@tombuildsstuff tombuildsstuff deleted the f/auth/cli-token branch November 27, 2018 11:04
tombuildsstuff added a commit that referenced this pull request Nov 27, 2018
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform loses access token and requires az login
3 participants