Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VM: ensuring we nil-check items prior to accessing #2365

Merged
merged 1 commit into from
Dec 4, 2018
Merged

Conversation

tombuildsstuff
Copy link
Contributor

Fixes #2359 - also adds a bunch of extra nil-checking where it made sense on the initial pass-through

Since we'll be doing some work in this area for 2.0 - this is a quick cleanup whilst passing through.

Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tombuildsstuff thanks for the PR, this is great and mostly LGTM left a couple of questions in the PR. Let me know what you think. Thanks!

azurerm/resource_arm_virtual_machine.go Show resolved Hide resolved
azurerm/resource_arm_virtual_machine.go Show resolved Hide resolved
@WodansSon
Copy link
Collaborator

@tombuildsstuff the build failed with 3 test failures, but I don't think they had anything to do with your code changes, looked more like issues inside of azure to me. I will leave it to you to decide what to do here. Thanks.

@tombuildsstuff
Copy link
Contributor Author

Ignoring a few transitory test failures the tests pass:

screenshot 2018-12-04 at 12 52 29

@tombuildsstuff tombuildsstuff merged commit 5496380 into master Dec 4, 2018
@tombuildsstuff tombuildsstuff deleted the b/vm-2359 branch December 4, 2018 12:52
tombuildsstuff added a commit that referenced this pull request Dec 4, 2018
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants