Monitor Activity Log Alert: add missing criteria fields

[liemnotliam]

This PR addresses #2140 by providing support for additional criteria fields. criteria.operation_name is now optional as it's not a required field for the API call.

Fixes #2140

Test results:

~/go/src/github.com/terraform-providers/terraform-provider-azurerm on activity-log-alert-criteria*
λ TESTARGS="-run TestAccAzureRMMonitorActivityLogAlert -count=1" make testacc
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccAzureRMMonitorActivityLogAlert -count=1 -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
?       github.com/terraform-providers/terraform-provider-azurerm       [no test files]
=== RUN   TestAccAzureRMMonitorActivityLogAlert_basic
--- PASS: TestAccAzureRMMonitorActivityLogAlert_basic (62.71s)
=== RUN   TestAccAzureRMMonitorActivityLogAlert_singleResource
--- PASS: TestAccAzureRMMonitorActivityLogAlert_singleResource (98.70s)
=== RUN   TestAccAzureRMMonitorActivityLogAlert_complete
--- PASS: TestAccAzureRMMonitorActivityLogAlert_complete (101.31s)
=== RUN   TestAccAzureRMMonitorActivityLogAlert_basicAndCompleteUpdate
--- PASS: TestAccAzureRMMonitorActivityLogAlert_basicAndCompleteUpdate (135.57s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm       398.322s
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/authentication        0.021s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/azure 0.036s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/kubernetes    0.010s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/response      0.027s [no tests to run]
?       github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/set   [no test files]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/suppress      0.036s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/validate      0.022s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/utils 0.029s [no tests to run]
?       github.com/terraform-providers/terraform-provider-azurerm/version       [no test files]

[katbyte]

Hi @liemnotliam,

Thank you for adding these fields! This PR LGTM 👍

[tombuildsstuff]

hi @liemnotliam

Just to let you know that this has been released as a part of v1.18 of the AzureRM Provider (the full changelog is available here). You can upgrade to this by specifying the version in the provider block (as shown below) and then running terraform init -upgrade

provider "azurerm" {
  version = "=1.18.0"
}

Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!