Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_public_ip: fixed domain name label validation #2122

Merged
merged 3 commits into from
Oct 21, 2018
Merged

azurerm_public_ip: fixed domain name label validation #2122

merged 3 commits into from
Oct 21, 2018

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Oct 20, 2018

fixes #2085

@katbyte katbyte added this to the 1.17.1 milestone Oct 20, 2018
@katbyte katbyte requested a review from a team October 20, 2018 01:00
@ghost ghost added the size/L label Oct 20, 2018
@katbyte katbyte mentioned this pull request Oct 20, 2018
Closed
WodansSon
WodansSon approved these changes Oct 20, 2018
View reviewed changes
Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katbyte LGTM, just get the Travis-ci build check to pass and I think we are good.

WodansSon
WodansSon approved these changes Oct 20, 2018
View reviewed changes
Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katbyte changes to the tests look good, thanks.

tombuildsstuff
tombuildsstuff approved these changes Oct 20, 2018
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM 👍

azurerm/helpers/validate/public_ip.go Outdated Show resolved Hide resolved
@katbyte katbyte merged commit 339d500 into master Oct 21, 2018
@katbyte katbyte deleted the b/public_ip-domain branch October 21, 2018 03:51
katbyte added a commit that referenced this pull request Oct 21, 2018
@katbyte
Update CHANGELOG.md to include #2122
a6e663e
@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@WodansSon WodansSon WodansSon approved these changes

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
bug service/public-ip size/L
Projects
None yet
Milestone
v1.18.0
Development

Successfully merging this pull request may close these issues.

azurerm_public_ip domain_name_label incorrectly limited to 61 chars
3 participants
@katbyte @tombuildsstuff @WodansSon