-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi-master for Azure Cosmos DB accounts #2109
Conversation
Hi @pietro, Thanks for the contribution, we will update the SKD in another PR |
SDK upgrade #2163 needs to be merged first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, however i think you need to update the test to check for an additional geo_location
as the test currently fails:
=== RUN TestAccAzureRMCosmosDBAccount_multiMaster
--- FAIL: TestAccAzureRMCosmosDBAccount_multiMaster (1997.78s)
testing.go:538: Step 0 error: Check failed: 1 error(s) occurred:
* Check 1/2 error: Check 8/15 error: azurerm_cosmosdb_account.test: Attribute 'geo_location.#' expected "1", got "2"
FAIL
Look forward to getting this merged once the test passes and the SDK update is merged 🙂
I hope you don't mind but i pushed some changes to fix the test so i could merge it today 🙂 |
@katbyte thanks for getting this merged! |
hi @pietro Just to let you know that this has been released as a part of v1.18 of the AzureRM Provider (the full changelog is available here). You can upgrade to this by specifying the version in the provider block (as shown below) and then running
Thanks! |
thanks for the heads up @tombuildsstuff! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
The go SDK needs to be updated for this PR but I don't know if I should do it in this PR or in another. So, I only updated the package for CosmosDB.