Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-master for Azure Cosmos DB accounts #2109

Merged
merged 6 commits into from
Oct 28, 2018

Conversation

pietro
Copy link
Contributor

@pietro pietro commented Oct 18, 2018

The go SDK needs to be updated for this PR but I don't know if I should do it in this PR or in another. So, I only updated the package for CosmosDB.

@ghost ghost added the size/M label Oct 18, 2018
@katbyte
Copy link
Collaborator

katbyte commented Oct 18, 2018

Hi @pietro,

Thanks for the contribution, we will update the SKD in another PR

@katbyte
Copy link
Collaborator

katbyte commented Oct 26, 2018

SDK upgrade #2163 needs to be merged first

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pietro,

This LGTM, however i think you need to update the test to check for an additional geo_location as the test currently fails:

=== RUN   TestAccAzureRMCosmosDBAccount_multiMaster
--- FAIL: TestAccAzureRMCosmosDBAccount_multiMaster (1997.78s)
	testing.go:538: Step 0 error: Check failed: 1 error(s) occurred:
		
		* Check 1/2 error: Check 8/15 error: azurerm_cosmosdb_account.test: Attribute 'geo_location.#' expected "1", got "2"
FAIL

Look forward to getting this merged once the test passes and the SDK update is merged 🙂

@katbyte
Copy link
Collaborator

katbyte commented Oct 28, 2018

@pietro,

I hope you don't mind but i pushed some changes to fix the test so i could merge it today 🙂

@katbyte katbyte modified the milestones: 1.19.0, 1.18.0 Oct 28, 2018
@katbyte katbyte merged commit a70c169 into hashicorp:master Oct 28, 2018
katbyte added a commit that referenced this pull request Oct 28, 2018
@pietro
Copy link
Contributor Author

pietro commented Oct 29, 2018

@katbyte thanks for getting this merged!

@pietro pietro deleted the multiplewritelocation branch October 29, 2018 20:42
@tombuildsstuff
Copy link
Contributor

hi @pietro

Just to let you know that this has been released as a part of v1.18 of the AzureRM Provider (the full changelog is available here). You can upgrade to this by specifying the version in the provider block (as shown below) and then running terraform init -upgrade

provider "azurerm" {
  version = "=1.18.0"
}

Thanks!

@pietro
Copy link
Contributor Author

pietro commented Nov 2, 2018

thanks for the heads up @tombuildsstuff!

@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants