New Resources: azurerm_dev_test_(linux|windows)virtual_machine
#2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katbyte
approved these changes
Oct 11, 2018
| galleryImageReference := expandDevTestLabVirtualMachineGalleryImageReference(galleryImageReferenceRaw, osType) | ||
|
|
||
| natRulesRaw := d.Get("inbound_nat_rule").(*schema.Set) | ||
| natRules := expandDevTestLabVirtualMachineNatRules(natRulesRaw) |
There was a problem hiding this comment.
Is there a reason why galleryImage is a ref and this is not?
There was a problem hiding this comment.
there's some validation below which needs the non-ref'd value to this, so it seemed simpler not to ref this in the function; but I can update that if needed?
tombuildsstuff
force-pushed
the
f/dtl-virtual-machine
branch
from
aeb275d to
d80b3c5
Compare
tombuildsstuff
force-pushed
the
f/dtl-virtual-machine
branch
3 times, most recently
from
b6893b2 to
99659be
Compare
tombuildsstuff
changed the title
azurerm_dev_test_virtual_machineazurerm_dev_test_(linux|windows)virtual_machine
tombuildsstuff
force-pushed
the
f/dtl-virtual-machine
branch
from
99659be to
5ea28a7
Compare
|
Tests pass:
|
mbfrahry
approved these changes
Oct 12, 2018
|
Ignoring a temporary error in the API - the tests still pass: |
tombuildsstuff
added a commit
that referenced
this pull request
Oct 12, 2018
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on #2041