Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use lower casing for OMS agent and correct solution for container monitoring #1995

Merged
merged 6 commits into from
Oct 2, 2018
Merged

Use lower casing for OMS agent and correct solution for container monitoring #1995

merged 6 commits into from
Oct 2, 2018

Conversation

metacpp
Copy link
Contributor

@metacpp metacpp commented Sep 28, 2018 •
edited by katbyte
Loading

This PR includes:

  1. Fix the issue omsAgent profile is wrongly cased - it should be omsagent all lowercase #1983 caused by camelCase issue of "omsAgent".
  2. Use ContainerInsights as the correct solution for container monitoring.
  3. Update test cases and docs.

(fixes #1983)

@metacpp
🐛 (Casing issue for OMS agent configuration.) Use lower casing for OM…
36b8c06 
…S agent.

Use lower casing to access OMS agent related configuration.
@metacpp
🐛 (OMS solution.) Use ContainerInsights instead.
af3565a 
Use ContainerInsights as solution name to make OMS agent be working with AKS.
@metacpp
✅ (OMS agent test for AKS.) Add log analytics solution for AKS test.
28df9fa 
Add log analytics solution configuration for AKS test.
@metacpp
🐛 (Update test and docs for AKS and log analytics solution.) Update t…
75cd129 
…est and docs.

Update test and docs to adopt AKS log analytics solution in AKS.
@ghost ghost added the size/M label Sep 28, 2018
@metacpp metacpp added this to the 1.17.0 milestone Sep 28, 2018
@metacpp metacpp changed the title Use lower casing for OMS agent profile setting Use lower casing for OMS agent and correct solution for container monitoring Sep 28, 2018
@metacpp
Copy link
Contributor Author

metacpp commented Sep 29, 2018

@ganga1980 please take a look at it.

tombuildsstuff
tombuildsstuff approved these changes Sep 30, 2018
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor issue but this otherwise LGTM 👍

website/docs/r/log_analytics_solution.html.markdown Outdated Show resolved Hide resolved
@metacpp
✏️ (Docs of log analytics solution.) Fix typo.
6c2466f 
Fix typo of ContainerInsights.
@metacpp
📝 (AKS documentation.) Add link to Azure monitor intergration.
765d15d 
Add link to Azure monitor on container for AKS.
@metacpp
Copy link
Contributor Author

metacpp commented Oct 1, 2018

Log Analytics Solution Tests passed:
image

AKS Tests passed:
image

katbyte
katbyte approved these changes Oct 2, 2018
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@metacpp, thanks for the update. LTGM 👍

@katbyte katbyte merged commit e66208e into master Oct 2, 2018
@katbyte katbyte deleted the oms_fix branch October 2, 2018 17:38
katbyte added a commit that referenced this pull request Oct 2, 2018
@katbyte
Update CHANGELOG.md to include #1995
9454c5e
@metacpp
Copy link
Contributor Author

metacpp commented Oct 2, 2018

@katbyte thanks for the merge!

@RiverPhillips
Copy link
Contributor

Any Idea when this will be released?

@metacpp
Copy link
Contributor Author

metacpp commented Oct 15, 2018 •
edited
Loading

@River991 it's planned in v1.17.0, we're very close to it.

@RiverPhillips
Copy link
Contributor

That's great news, would really help me out to have logging

@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

@WodansSon WodansSon Awaiting requested review from WodansSon

Assignees
No one assigned
Labels
bug service/kubernetes-cluster size/M
Projects
None yet
Milestone
v1.17.0
Development

Successfully merging this pull request may close these issues.

omsAgent profile is wrongly cased - it should be omsagent all lowercase
4 participants
@metacpp @RiverPhillips @tombuildsstuff @katbyte