-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_azuread_application urls are now required to be https #1960
Conversation
tests pass:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Hi! I'm wondering if the root cause of this behavior was incorrectly diagnosed, or if maybe Azure have changed their API again. If i peg my
In other words, I cannot reproduce the original issue (#1953). However, as of this PR and version
Again, this template applies successfully with 1.15 but fails on 1.16. This effectively makes impossible to e.g. set reply urls for AzureAD applications that enable local testing of OAuth flows (without configuring your local development environment to run https). Is there any chance this PR could be reverted for 1.17, to re-enable this configuration? PS. This template, touching all three types of URLs and setting them to HTTP-schemed values, also works without problems on 1.15:
|
Ping @katbyte @tombuildsstuff - just making sure this didn't fall under the radar because the issue is already closed :) |
@tomasaschan since this issue is closed - would you open a separate issue about that? Thanks! |
@tombuildsstuff No probs - see #2130 :) |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
fixes #1953
existing tests are failing: