Removed validation from arm_function_app #1872
Conversation
There was a problem hiding this comment.
hey @JimPaine
Thanks for this PR - if we can remove the entry from the CHANGELOG (which I'll push a commit to fix) this otherwise LGTM 👍
Thanks!
CHANGELOG.md
Outdated
| @@ -14,6 +14,7 @@ IMPROVEMENTS: | |||
| * `azurerm_storage_container` - support for import [GH-1816] | |||
| * `azurerm_storage_queue` - support for import [GH-1816] | |||
| * `azurerm_storage_table` - support for import [GH-1816] | |||
| * `azurerm_function_app` - support for specific versions [GH-1731] | |||
There was a problem hiding this comment.
can you revert this change? we update the CHANGELOG once things are merged to prevent conflicts (since this file changes frequently)
|
hey @JimPaine I hope you don't mind but I've pushed a commit to fix the failing test and now the tests pass / this LGTM 👍 - thanks for this :)
Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
As mentioned in GH-1731 There are times when you are required to pin the runtime version to a specific version. Also highlighted with this breaking change
Validation has been removed from the version property on arm_function_app and tests updated to validated updating versions still work.
Tests are passing and I have built it and run the provider with a .NET Standard 2 app with using pinned versions and V2.