Data Disk Attachment: obtaining a basic view of the VM rather than the Instance View

[tombuildsstuff]

This matches the usages across the Provider which I believe should should fix #1600 - but I've been unable to reliably reproduce that issue. Additional context is in this comment: #1600 (comment)

[tombuildsstuff]

Tests pass for this branch:

[bflad]

LGTM 👍

[whytoe]

@tombuildsstuff I am still having issues with this

• provider.azurerm: version = "~> 1.14"

• azurerm_virtual_machine_data_disk_attachment.attach: Error updating Virtual Machine "myVM" (Resource Group "myRGP") with Disk "myVM-disk1": compute.VirtualMachinesClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="InvalidRequestContent" Message="The request content was invalid and could not be deserialized: 'Could not find member 'resources' on object of type 'ResourceDefinition'. Path 'resources', line 1, position 2049.'."

[tombuildsstuff]

@whytoe sorry to hear this is still an issue for you - I've spent a while trying to repro this and have been unsuccessful, unfortunately - so this was a best effort fix without being able to verify one way or the other.

Out of interest is this happening repeatedly for you? If so - would you be able to capture the http traffic (using either TF_LOG=1 or a Proxy of some kind [e.g. Charles Proxy/Fiddler and http_proxy=http://localhost:8888 https_proxy=http://localhost:8888 terraform plan]) so that we could investigate this further?

Thanks!

[whytoe]

@tombuildsstuff ya I saw the other thread and didn't want to take over someone else issue
Give me 20 minutes

[tombuildsstuff]

@whytoe awesome, thanks a lot :)

[whytoe]

@tombuildsstuff I forgot to tag you in this post, oops

https://gist.github.com/whytoe/64ea636330940c41d6edab976d9317d0
I changed VM, Subscription and any unique identifiers to myResource format

It looks like the api is not accepting the json post

Here is the Microsoft Rest API documentation for the API 2017-12-01

https://docs.microsoft.com/en-us/rest/api/compute/virtualmachines/createorupdate#create_a_vm_with_empty_data_disks.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!