Remove client side validation for azure network plugin #1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etwork plugin. Non-empty podCidr string validation for azure network plugin should be handled by ASK service.
Add more explainations on default network_profile and `azure` specific validation requirement.
tombuildsstuff
approved these changes
Aug 21, 2018
| @@ -266,6 +267,7 @@ A `network_profile` block supports the following: | |||
| * `docker_bridge_cidr` - (Optional) IP address (in CIDR notation) used as the Docker bridge IP address on nodes. This is required when `network_plugin` is set to `kubenet`. Changing this forces a new resource to be created. | |||
|
|
|||
| * `pod_cidr` - (Optional) The CIDR to use for pod IP addresses. Changing this forces a new resource to be created. | |||
| -> **NOTE:** When `network_plugin` is set to `azure` - the `pod_cidr` filed should be ignored. | |||
There was a problem hiding this comment.
we normally integrate this into the field description e.g.
* `pod_cidr` - (Optional) The CIDR to use for pod IP addresses. This field can only be set when `network_plugin` is set to `kubenet`. Changing this forces a new resource to be created.
There was a problem hiding this comment.
Pushed a commit to fix this, since this is minor
tombuildsstuff
added a commit
that referenced
this pull request
Aug 21, 2018
torresdal
added a commit
to torresdal/terraform-provider-azurerm
that referenced
this pull request
Aug 23, 2018
* master: (95 commits) Some more AzureStack changes for route table resource and datasource (hashicorp#1807) backport AzureStack route resource PR comments (hashicorp#1810) Updating to include hashicorp#1799 Bug Fix of azurerm_virtual_machine.storage_os_disk.image_uri (hashicorp#1799) Updating to include hashicorp#1693 IoT Hub add endpoints and routes (hashicorp#1693) Updating to include hashicorp#1789 Added support for EventHub compatible EndPoints and Paths (hashicorp#1789) Updating to include hashicorp#1798 Remove client side validation for azure network plugin (hashicorp#1798) backport azure stack route_table PR review comments (hashicorp#1790) Update CHAGELOG.md to include hashicorp#1795 Fix: Corrected regexp for eventhub name reset verb fix some pointer dereferences Fix indentation on application_gateway.html.markdown (hashicorp#1780) folded subscription and [az]schema packages into azure consolidate CaseDifference Supression functions Cleanup after v1.13.0 release v1.13.0 ...
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the validation logic to handle non-empty
pod_cidrwhilenetwork_pluginisazure, coz it causes #1783 .Actually, AKS team added the below logic to reject non-empty
pod_cidrexplicitly to avoid confusing theTerraform Plan:Please see Azure/acs-engine#3562 for details.
For some reason, the fix is not deployed successfully, I am working with AKS team to get it work correctly.
Acceptance Test Results:
Synced with AKS team, the fix is planned for v0.21.0-rc1:
Azure/acs-engine@1321003