New data source: azurerm_log_analytics_workspace

[TechyMatt]

No description provided.

[tombuildsstuff]

hey @mb290

Thanks for this PR - I've left a few minor comments inline but if we can fix those up this otherwise LGTM 👍

Thanks!

[tombuildsstuff]

can we update this to be resourceGroupNameForDataSourceSchema?

[tombuildsstuff]

can we also add retention_in_days, sku and tags here?

[tombuildsstuff]

minor we could probably switch to using the basic resource from the Resource instead here? e.g. testAccAzureRMLogAnalyticsWorkspace_requiredOnly

[TechyMatt]

Hi @tombuildsstuff! Changes have been made. Didn't think/know about being able to leverage the resource from the resource test case so have updated it. Let me know if it's not the right way.

[TechyMatt]

@tombuildsstuff after a couple of failed builds and understanding the test harness much more I ended up using

testAccAzureRMLogAnalyticsWorkspace_retentionInDaysComplete

One of my tests was for the number of days retention so I wanted to make sure we aren't expecting MS to keep the same value, instead we can just use what we set. I also updated the expected Sku based on the new test case.

[katbyte]

@mb290,

Thank you for the requested updates, this LGTM now 👍

[katbyte]

Tests pass:

gofmt -w $(find . -name '*.go' |grep -v vendor)
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -test.run=TestAccDataSourceAzureRMLogAnalyticsWorkspace -timeout 180m
=== RUN   TestAccDataSourceAzureRMLogAnalyticsWorkspace_basic
--- PASS: TestAccDataSourceAzureRMLogAnalyticsWorkspace_basic (91.97s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	92.005s

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!